Merged
Conversation
Following https://reactrouter.com/upgrading/remix, I did `npx codemod remix/2/react-router/upgrade`, `pnpm install`, and `pnpm lint --fix` (to get rid of semi colons)
It's possible we'll want to customize the entry points in the future, but this change is what it took to get the app to function at all
navigate is now async so needs to be handled as such
bigdogwillfeed
changed the base branch from
herb/contain-effect-to-data-layer
to
main
# Conflicts: # pnpm-lock.yaml
replaced this extra bit of remix still lurking with the proper react-router syntax
react-router says it needs this
bigdogwillfeed
force-pushed
the
react-router
branch
from
ca86ada to
4983e99
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We used to be using remix, and the future of that framework is react router. So I followed the upgrade docs https://reactrouter.com/upgrading/remix
The most important change here is 5fc826a, where I removed the client and server entries. To get that completely working, I also needed to merge index.html and root.tsx. I don't know what all the entry files were doing for us, but going back to a more off-the-shelf react router setup was necessary to get the app to render anything at all