Skip to content

Conversation

@chaosmirage
Copy link
Contributor

@chaosmirage chaosmirage commented Dec 24, 2025

No description provided.

@chaosmirage chaosmirage requested a review from a team December 24, 2025 16:08
@chaosmirage chaosmirage self-assigned this Dec 24, 2025
Copilot AI review requested due to automatic review settings December 24, 2025 16:08
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR creates a new Nx-based localization executor to replace the existing Gulp-based localization task, modernizing the build system infrastructure. The implementation generates localization message files and TypeScript CLDR data modules, and enhances the add-license-headers executor with custom template support.

Key Changes

  • New localization executor that generates message files and CLDR TypeScript modules using lodash templates
  • Enhanced add-license-headers executor with custom template support, EULA URL configuration, and prepend-after-license functionality
  • Integration of localization tasks into devextreme project.json with proper Nx caching and dependency management

Reviewed changes

Copilot reviewed 12 out of 13 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
pnpm-lock.yaml Adds lodash and @types/lodash dependencies; includes minor formatting change to Q package deprecation message
packages/nx-infra-plugin/src/executors/localization/schema.ts Defines TypeScript interface for localization executor options
packages/nx-infra-plugin/src/executors/localization/schema.json JSON schema for localization executor with configurable paths and skip flags
packages/nx-infra-plugin/src/executors/localization/executor.ts Core implementation that generates localization messages and CLDR modules, replacing Gulp-based approach
packages/nx-infra-plugin/src/executors/localization/executor.e2e.spec.ts E2E tests verifying message file and CLDR module generation
packages/nx-infra-plugin/src/executors/add-license-headers/schema.ts Extends schema with custom template, EULA URL, and prepend options
packages/nx-infra-plugin/src/executors/add-license-headers/schema.json Adds JSON schema definitions for new license header features
packages/nx-infra-plugin/src/executors/add-license-headers/executor.ts Refactors and extends license header executor with custom template support using lodash
packages/nx-infra-plugin/src/executors/add-license-headers/executor.e2e.spec.ts Adds test for custom license template and consolidates header validation tests
packages/nx-infra-plugin/package.json Adds lodash and @types/lodash as dependencies
packages/nx-infra-plugin/executors.json Registers new localization executor
packages/devextreme/project.json Defines new localization build targets (generate, headers, composite) with Nx caching
nx.json Adds named inputs for devextreme sources and build configuration
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

@chaosmirage chaosmirage force-pushed the feat/migrate-devextreme-to-nx-part-1 branch from cbb0822 to cbbb0aa Compare December 24, 2025 16:26
Copilot AI review requested due to automatic review settings January 7, 2026 09:45
@chaosmirage chaosmirage force-pushed the feat/migrate-devextreme-to-nx-part-1 branch from cbbb0aa to 2e1c102 Compare January 7, 2026 09:45
@chaosmirage chaosmirage force-pushed the feat/migrate-devextreme-to-nx-part-1 branch from 2e1c102 to 94fe0f0 Compare January 7, 2026 09:46
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 14 out of 15 changed files in this pull request and generated 3 comments.

Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

sh.exec('pnpm run all:pack-and-copy');

sh.exec('pnpx nx pack devextreme-react', { silent: true });
sh.exec('pnpx nx pack devextreme-react', { silent: false });
Copy link

Copilot AI Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change from silent: true to silent: false appears to be a debug leftover. This change should be reverted to maintain consistency with the other pack commands on lines 82 and 83, which keep silent: true.

Suggested change
sh.exec('pnpx nx pack devextreme-react', { silent: false });
sh.exec('pnpx nx pack devextreme-react', { silent: true });

Copilot uses AI. Check for mistakes.
Comment on lines 15035 to 15045
You or someone you depend on is using Q, the JavaScript Promise library that gave JavaScript developers strong feelings about promises. They can almost certainly migrate to the native JavaScript promise now. Thank you literally everyone for joining me in this bet against the odds. Be excellent to each other.

(For a CapTP with native promises, see @endo/eventual-send and @endo/captp)
Copy link

Copilot AI Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removal of the blank line in the deprecated message for the 'q' package is a whitespace-only change that doesn't appear related to the purpose of this PR. This change should be reverted to avoid unrelated modifications to the lockfile.

Copilot uses AI. Check for mistakes.
@chaosmirage chaosmirage force-pushed the feat/migrate-devextreme-to-nx-part-1 branch from 94fe0f0 to e07f880 Compare January 7, 2026 14:40
@chaosmirage chaosmirage requested a review from a team as a code owner January 7, 2026 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant