Skip to content

Fix add-devices --server command error#304

Merged
anoworl merged 1 commit intomasterfrom
fix/add_devices_server
Nov 1, 2022
Merged

Fix add-devices --server command error#304
anoworl merged 1 commit intomasterfrom
fix/add_devices_server

Conversation

@anoworl
Copy link
Contributor

@anoworl anoworl commented Oct 31, 2022

I fixed add-devices --server command error.
This error maybe occurred from #270 .

Before

I ran this command and installed a configuration profile to a device and got the exception.

$ dg add-devices --server --distribution-key XXXX
Start add-devices server. Use Ctrl-C to stop.
New device has been added. Start add-devices command.
Device [Name: iPod touch (7 Gen), UDID: xxxx] successfully registered.
Your Workers::Worker exception handler raised an error. Fix your handler!
ArgumentError: wrong number of arguments (given 3, expected 4)
/Users/sota/.rvm/gems/ruby-2.6.9/gems/deploygate-0.8.4/lib/deploygate/commands/add_devices.rb:72:in `build!'
/Users/sota/.rvm/gems/ruby-2.6.9/gems/deploygate-0.8.4/lib/deploygate/add_devices_server.rb:47:in `block in build'
/Users/sota/.rvm/gems/ruby-2.6.9/gems/workers-0.6.1/lib/workers/worker.rb:101:in `perform_handler'
/Users/sota/.rvm/gems/ruby-2.6.9/gems/workers-0.6.1/lib/workers/worker.rb:86:in `event_handler'
/Users/sota/.rvm/gems/ruby-2.6.9/gems/workers-0.6.1/lib/workers/worker.rb:73:in `process_event'
/Users/sota/.rvm/gems/ruby-2.6.9/gems/workers-0.6.1/lib/workers/worker.rb:67:in `start_event_loop'
/Users/sota/.rvm/gems/ruby-2.6.9/gems/workers-0.6.1/lib/workers/worker.rb:13:in `block in initialize'

After

I ran this command and installed a configuration profile to a device and succeed the command.

$ dg add-devices --server --distribution-key XXXX
Start add-devices server. Use Ctrl-C to stop.
New device has been added. Start add-devices command.
Device [Name: iPod touch (7 Gen), UDID: xxxx] successfully registered.

+-------------------------------------+---------------------+
|                 Summary for sigh 2.148.1                  |
+-------------------------------------+---------------------+
| adhoc                               | true                |
...
add-devices completed successfully.

@anoworl anoworl force-pushed the fix/add_devices_server branch from b5619f8 to 0206117 Compare October 31, 2022 12:03
@anoworl anoworl marked this pull request as ready for review October 31, 2022 12:07
@jmatsu jmatsu self-requested a review November 1, 2022 02:00
Copy link
Contributor

@jmatsu jmatsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😮 ... LGTM

@anoworl
Copy link
Contributor Author

anoworl commented Nov 1, 2022

Thank you! 🙏

@anoworl anoworl merged commit f2bea4c into master Nov 1, 2022
@anoworl anoworl deleted the fix/add_devices_server branch November 1, 2022 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants