Do not exit command even if checking version fail#286
Merged
jiikko merged 2 commits intoDeployGate:masterfrom Oct 29, 2020
jiikko:safe-check
Merged
Do not exit command even if checking version fail#286jiikko merged 2 commits intoDeployGate:masterfrom jiikko:safe-check
jiikko merged 2 commits intoDeployGate:masterfrom
jiikko:safe-check
Conversation
jiikko
changed the title
jmatsu
suggested changes
Oct 29, 2020
config/locales/en.yml
Outdated
| ################################################################# | ||
| not_internet_connection_error: 'Error: Not internet connection. Please by connecting to the internet' | ||
| commands: | ||
| _setup: |
Contributor
There was a problem hiding this comment.
What does it mean by starting with an underscore?
I guess it would be better to move this section up to the upper level and define errors section like the following.
errors:
check_update_failure: ...
commands: ...
Contributor
Author
There was a problem hiding this comment.
thanks you for comment!
i wanted to show like private method...
sound good! i try it!
Contributor
Author
|
thank you!!!!!!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related #284