-
Notifications
You must be signed in to change notification settings - Fork 324
Fix aws-sdk kinesis defaulting to HTTP2 with ALPN, but test server supports only h2c
#10358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+11
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… test server only support HTTP2c
… test server only support HTTP2c
575eaca to
fee72a0
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 8 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~fee72a058c, baseline=1.59.0-SNAPSHOT~d5579167e9
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.091 s) : 0, 1090576
Total [baseline] (8.775 s) : 0, 8774874
Agent [candidate] (1.1 s) : 0, 1100186
Total [candidate] (8.808 s) : 0, 8807642
section iast
Agent [baseline] (1.224 s) : 0, 1223589
Total [baseline] (9.317 s) : 0, 9317282
Agent [candidate] (1.234 s) : 0, 1234053
Total [candidate] (9.417 s) : 0, 9417260
gantt
title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~fee72a058c, baseline=1.59.0-SNAPSHOT~d5579167e9
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.218 ms) : 0, 1218
crashtracking [candidate] (1.205 ms) : 0, 1205
BytebuddyAgent [baseline] (655.793 ms) : 0, 655793
BytebuddyAgent [candidate] (662.088 ms) : 0, 662088
GlobalTracer [baseline] (284.29 ms) : 0, 284290
GlobalTracer [candidate] (286.803 ms) : 0, 286803
AppSec [baseline] (32.782 ms) : 0, 32782
AppSec [candidate] (33.08 ms) : 0, 33080
Debugger [baseline] (67.412 ms) : 0, 67412
Debugger [candidate] (67.747 ms) : 0, 67747
Remote Config [baseline] (648.817 µs) : 0, 649
Remote Config [candidate] (644.927 µs) : 0, 645
Telemetry [baseline] (8.967 ms) : 0, 8967
Telemetry [candidate] (8.991 ms) : 0, 8991
Flare Poller [baseline] (3.791 ms) : 0, 3791
Flare Poller [candidate] (3.783 ms) : 0, 3783
section iast
crashtracking [baseline] (1.195 ms) : 0, 1195
crashtracking [candidate] (1.192 ms) : 0, 1192
BytebuddyAgent [baseline] (791.714 ms) : 0, 791714
BytebuddyAgent [candidate] (796.17 ms) : 0, 796170
GlobalTracer [baseline] (256.698 ms) : 0, 256698
GlobalTracer [candidate] (260.353 ms) : 0, 260353
AppSec [baseline] (33.494 ms) : 0, 33494
AppSec [candidate] (34.211 ms) : 0, 34211
Debugger [baseline] (65.431 ms) : 0, 65431
Debugger [candidate] (65.948 ms) : 0, 65948
Remote Config [baseline] (588.443 µs) : 0, 588
Remote Config [candidate] (592.902 µs) : 0, 593
Telemetry [baseline] (8.461 ms) : 0, 8461
Telemetry [candidate] (8.701 ms) : 0, 8701
Flare Poller [baseline] (3.581 ms) : 0, 3581
Flare Poller [candidate] (3.699 ms) : 0, 3699
IAST [baseline] (26.908 ms) : 0, 26908
IAST [candidate] (27.481 ms) : 0, 27481
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~fee72a058c, baseline=1.59.0-SNAPSHOT~d5579167e9
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.085 s) : 0, 1085166
Total [baseline] (10.77 s) : 0, 10770399
Agent [candidate] (1.088 s) : 0, 1088071
Total [candidate] (10.821 s) : 0, 10820517
section appsec
Agent [baseline] (1.264 s) : 0, 1264057
Total [baseline] (11.113 s) : 0, 11112989
Agent [candidate] (1.265 s) : 0, 1265187
Total [candidate] (11.0 s) : 0, 11000152
section iast
Agent [baseline] (1.224 s) : 0, 1224343
Total [baseline] (11.223 s) : 0, 11223490
Agent [candidate] (1.242 s) : 0, 1241537
Total [candidate] (11.251 s) : 0, 11251356
section profiling
Agent [baseline] (1.204 s) : 0, 1203827
Total [baseline] (10.988 s) : 0, 10987749
Agent [candidate] (1.208 s) : 0, 1208450
Total [candidate] (10.864 s) : 0, 10864338
gantt
title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~fee72a058c, baseline=1.59.0-SNAPSHOT~d5579167e9
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.202 ms) : 0, 1202
crashtracking [candidate] (1.193 ms) : 0, 1193
BytebuddyAgent [baseline] (651.385 ms) : 0, 651385
BytebuddyAgent [candidate] (653.792 ms) : 0, 653792
GlobalTracer [baseline] (282.892 ms) : 0, 282892
GlobalTracer [candidate] (283.029 ms) : 0, 283029
AppSec [baseline] (32.622 ms) : 0, 32622
AppSec [candidate] (32.726 ms) : 0, 32726
Debugger [baseline] (68.096 ms) : 0, 68096
Debugger [candidate] (68.01 ms) : 0, 68010
Remote Config [baseline] (646.216 µs) : 0, 646
Remote Config [candidate] (660.294 µs) : 0, 660
Telemetry [baseline] (8.981 ms) : 0, 8981
Telemetry [candidate] (9.115 ms) : 0, 9115
Flare Poller [baseline] (3.86 ms) : 0, 3860
Flare Poller [candidate] (3.865 ms) : 0, 3865
section appsec
crashtracking [baseline] (1.18 ms) : 0, 1180
crashtracking [candidate] (1.183 ms) : 0, 1183
BytebuddyAgent [baseline] (689.265 ms) : 0, 689265
BytebuddyAgent [candidate] (691.462 ms) : 0, 691462
GlobalTracer [baseline] (258.105 ms) : 0, 258105
GlobalTracer [candidate] (258.67 ms) : 0, 258670
AppSec [baseline] (172.561 ms) : 0, 172561
AppSec [candidate] (172.883 ms) : 0, 172883
Debugger [baseline] (69.138 ms) : 0, 69138
Debugger [candidate] (67.142 ms) : 0, 67142
Remote Config [baseline] (765.902 µs) : 0, 766
Remote Config [candidate] (783.722 µs) : 0, 784
Telemetry [baseline] (9.438 ms) : 0, 9438
Telemetry [candidate] (9.325 ms) : 0, 9325
Flare Poller [baseline] (3.815 ms) : 0, 3815
Flare Poller [candidate] (3.818 ms) : 0, 3818
IAST [baseline] (24.446 ms) : 0, 24446
IAST [candidate] (24.552 ms) : 0, 24552
section iast
crashtracking [baseline] (1.173 ms) : 0, 1173
crashtracking [candidate] (1.198 ms) : 0, 1198
BytebuddyAgent [baseline] (790.947 ms) : 0, 790947
BytebuddyAgent [candidate] (803.403 ms) : 0, 803403
GlobalTracer [baseline] (256.454 ms) : 0, 256454
GlobalTracer [candidate] (260.061 ms) : 0, 260061
AppSec [baseline] (33.636 ms) : 0, 33636
AppSec [candidate] (35.023 ms) : 0, 35023
Debugger [baseline] (67.046 ms) : 0, 67046
Debugger [candidate] (65.983 ms) : 0, 65983
Remote Config [baseline] (584.442 µs) : 0, 584
Remote Config [candidate] (619.01 µs) : 0, 619
Telemetry [baseline] (8.505 ms) : 0, 8505
Telemetry [candidate] (8.603 ms) : 0, 8603
Flare Poller [baseline] (3.593 ms) : 0, 3593
Flare Poller [candidate] (3.604 ms) : 0, 3604
IAST [baseline] (26.984 ms) : 0, 26984
IAST [candidate] (27.346 ms) : 0, 27346
section profiling
ProfilingAgent [baseline] (96.952 ms) : 0, 96952
ProfilingAgent [candidate] (96.374 ms) : 0, 96374
crashtracking [baseline] (1.212 ms) : 0, 1212
crashtracking [candidate] (1.227 ms) : 0, 1227
BytebuddyAgent [baseline] (702.066 ms) : 0, 702066
BytebuddyAgent [candidate] (705.854 ms) : 0, 705854
GlobalTracer [baseline] (220.718 ms) : 0, 220718
GlobalTracer [candidate] (221.384 ms) : 0, 221384
AppSec [baseline] (31.977 ms) : 0, 31977
AppSec [candidate] (31.987 ms) : 0, 31987
Debugger [baseline] (67.718 ms) : 0, 67718
Debugger [candidate] (67.999 ms) : 0, 67999
Remote Config [baseline] (641.895 µs) : 0, 642
Remote Config [candidate] (665.431 µs) : 0, 665
Telemetry [baseline] (8.923 ms) : 0, 8923
Telemetry [candidate] (8.987 ms) : 0, 8987
Flare Poller [baseline] (3.737 ms) : 0, 3737
Flare Poller [candidate] (3.741 ms) : 0, 3741
Profiling [baseline] (97.523 ms) : 0, 97523
Profiling [candidate] (96.95 ms) : 0, 96950
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 2 performance regressions! Performance is the same for 16 metrics, 17 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~fee72a058c, baseline=1.59.0-SNAPSHOT~d5579167e9
dateFormat X
axisFormat %s
section baseline
no_agent (17.005 ms) : 16832, 17177
. : milestone, 17005,
appsec (18.257 ms) : 18073, 18442
. : milestone, 18257,
code_origins (17.649 ms) : 17476, 17823
. : milestone, 17649,
iast (18.553 ms) : 18366, 18740
. : milestone, 18553,
profiling (18.814 ms) : 18627, 19001
. : milestone, 18814,
tracing (17.713 ms) : 17534, 17893
. : milestone, 17713,
section candidate
no_agent (17.983 ms) : 17798, 18168
. : milestone, 17983,
appsec (18.534 ms) : 18347, 18721
. : milestone, 18534,
code_origins (17.49 ms) : 17319, 17661
. : milestone, 17490,
iast (17.619 ms) : 17442, 17797
. : milestone, 17619,
profiling (18.515 ms) : 18326, 18703
. : milestone, 18515,
tracing (17.565 ms) : 17390, 17740
. : milestone, 17565,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~fee72a058c, baseline=1.59.0-SNAPSHOT~d5579167e9
dateFormat X
axisFormat %s
section baseline
no_agent (1.172 ms) : 1161, 1184
. : milestone, 1172,
iast (3.146 ms) : 3104, 3188
. : milestone, 3146,
iast_FULL (5.741 ms) : 5685, 5797
. : milestone, 5741,
iast_GLOBAL (3.381 ms) : 3333, 3428
. : milestone, 3381,
profiling (2.027 ms) : 2008, 2045
. : milestone, 2027,
tracing (1.889 ms) : 1872, 1905
. : milestone, 1889,
section candidate
no_agent (1.189 ms) : 1177, 1201
. : milestone, 1189,
iast (3.193 ms) : 3152, 3234
. : milestone, 3193,
iast_FULL (5.637 ms) : 5581, 5693
. : milestone, 5637,
iast_GLOBAL (3.545 ms) : 3486, 3603
. : milestone, 3545,
profiling (1.969 ms) : 1952, 1986
. : milestone, 1969,
tracing (1.82 ms) : 1805, 1835
. : milestone, 1820,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~fee72a058c, baseline=1.59.0-SNAPSHOT~d5579167e9
dateFormat X
axisFormat %s
section baseline
no_agent (1.478 ms) : 1466, 1489
. : milestone, 1478,
appsec (3.689 ms) : 3467, 3910
. : milestone, 3689,
iast (2.211 ms) : 2146, 2277
. : milestone, 2211,
iast_GLOBAL (2.253 ms) : 2188, 2318
. : milestone, 2253,
profiling (2.476 ms) : 2315, 2637
. : milestone, 2476,
tracing (2.046 ms) : 1995, 2098
. : milestone, 2046,
section candidate
no_agent (1.475 ms) : 1464, 1487
. : milestone, 1475,
appsec (3.736 ms) : 3516, 3955
. : milestone, 3736,
iast (2.222 ms) : 2157, 2288
. : milestone, 2222,
iast_GLOBAL (2.26 ms) : 2194, 2325
. : milestone, 2260,
profiling (2.476 ms) : 2322, 2630
. : milestone, 2476,
tracing (2.045 ms) : 1993, 2096
. : milestone, 2045,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~fee72a058c, baseline=1.59.0-SNAPSHOT~d5579167e9
dateFormat X
axisFormat %s
section baseline
no_agent (14.996 s) : 14996000, 14996000
. : milestone, 14996000,
appsec (14.885 s) : 14885000, 14885000
. : milestone, 14885000,
iast (18.25 s) : 18250000, 18250000
. : milestone, 18250000,
iast_GLOBAL (18.046 s) : 18046000, 18046000
. : milestone, 18046000,
profiling (15.301 s) : 15301000, 15301000
. : milestone, 15301000,
tracing (14.617 s) : 14617000, 14617000
. : milestone, 14617000,
section candidate
no_agent (15.639 s) : 15639000, 15639000
. : milestone, 15639000,
appsec (14.392 s) : 14392000, 14392000
. : milestone, 14392000,
iast (17.992 s) : 17992000, 17992000
. : milestone, 17992000,
iast_GLOBAL (17.656 s) : 17656000, 17656000
. : milestone, 17656000,
profiling (14.798 s) : 14798000, 14798000
. : milestone, 14798000,
tracing (14.633 s) : 14633000, 14633000
. : milestone, 14633000,
|
h2c
amarziali
approved these changes
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
inst: aws sdk
AWS SDK instrumentation
tag: no release notes
Changes to exclude from release notes
type: bug
Bug report and fix
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
The AWS
KinesisAsyncClientdefaults to HTTP/2 protocol with ALPN, while the test server is customized to use HTTP/2 cleartext (h2c) viaHTTP2CServerConnectionFactory.Since the AWS SDK's Netty client uses ALPN for HTTP/2 negotiation, this caused
ClosedChannelException.There is a way to configure the protocol negotiation for
h2to tryh2cprior ALPN exchange, however this option require at least the aws sdk 2.25+. So this PR explicitly configures the async client of this test to rely on HTTP 1.1.While it would have been possible to setup APLN on the test server, this would have made the setup more complex with TLS and trust store. While the goal is to test the AWS SDK only, not the transport.
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]