-
Notifications
You must be signed in to change notification settings - Fork 324
Ledger.reset should reset containsRemoval status #10338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 56 metrics, 9 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~d08c29d98a, baseline=1.59.0-SNAPSHOT~c072939fa1
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.084 s) : 0, 1083559
Total [baseline] (8.793 s) : 0, 8792736
Agent [candidate] (1.09 s) : 0, 1089658
Total [candidate] (8.767 s) : 0, 8767417
section iast
Agent [baseline] (1.231 s) : 0, 1230979
Total [baseline] (9.343 s) : 0, 9342986
Agent [candidate] (1.224 s) : 0, 1223657
Total [candidate] (9.338 s) : 0, 9338115
gantt
title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~d08c29d98a, baseline=1.59.0-SNAPSHOT~c072939fa1
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.198 ms) : 0, 1198
crashtracking [candidate] (1.197 ms) : 0, 1197
BytebuddyAgent [baseline] (651.184 ms) : 0, 651184
BytebuddyAgent [candidate] (654.604 ms) : 0, 654604
GlobalTracer [baseline] (282.363 ms) : 0, 282363
GlobalTracer [candidate] (284.079 ms) : 0, 284079
AppSec [baseline] (32.712 ms) : 0, 32712
AppSec [candidate] (32.71 ms) : 0, 32710
Debugger [baseline] (67.025 ms) : 0, 67025
Debugger [candidate] (67.772 ms) : 0, 67772
Remote Config [baseline] (638.2 µs) : 0, 638
Remote Config [candidate] (652.892 µs) : 0, 653
Telemetry [baseline] (8.985 ms) : 0, 8985
Telemetry [candidate] (9.015 ms) : 0, 9015
Flare Poller [baseline] (3.771 ms) : 0, 3771
Flare Poller [candidate] (3.725 ms) : 0, 3725
section iast
crashtracking [baseline] (1.193 ms) : 0, 1193
crashtracking [candidate] (1.187 ms) : 0, 1187
BytebuddyAgent [baseline] (797.555 ms) : 0, 797555
BytebuddyAgent [candidate] (790.726 ms) : 0, 790726
GlobalTracer [baseline] (257.92 ms) : 0, 257920
GlobalTracer [candidate] (256.412 ms) : 0, 256412
AppSec [baseline] (33.67 ms) : 0, 33670
AppSec [candidate] (32.772 ms) : 0, 32772
Debugger [baseline] (65.422 ms) : 0, 65422
Debugger [candidate] (67.09 ms) : 0, 67090
Remote Config [baseline] (566.327 µs) : 0, 566
Remote Config [candidate] (571.733 µs) : 0, 572
Telemetry [baseline] (8.45 ms) : 0, 8450
Telemetry [candidate] (8.62 ms) : 0, 8620
Flare Poller [baseline] (3.587 ms) : 0, 3587
Flare Poller [candidate] (3.578 ms) : 0, 3578
IAST [baseline] (26.913 ms) : 0, 26913
IAST [candidate] (26.985 ms) : 0, 26985
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~d08c29d98a, baseline=1.59.0-SNAPSHOT~c072939fa1
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.085 s) : 0, 1085312
Total [baseline] (10.766 s) : 0, 10766004
Agent [candidate] (1.085 s) : 0, 1084879
Total [candidate] (10.698 s) : 0, 10697851
section appsec
Agent [baseline] (1.267 s) : 0, 1267219
Total [baseline] (11.083 s) : 0, 11082835
Agent [candidate] (1.269 s) : 0, 1268630
Total [candidate] (11.025 s) : 0, 11025351
section iast
Agent [baseline] (1.226 s) : 0, 1225596
Total [baseline] (11.182 s) : 0, 11181532
Agent [candidate] (1.235 s) : 0, 1235092
Total [candidate] (11.167 s) : 0, 11166978
section profiling
Agent [baseline] (1.22 s) : 0, 1220281
Total [baseline] (10.876 s) : 0, 10876064
Agent [candidate] (1.207 s) : 0, 1206532
Total [candidate] (11.06 s) : 0, 11060494
gantt
title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~d08c29d98a, baseline=1.59.0-SNAPSHOT~c072939fa1
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.198 ms) : 0, 1198
crashtracking [candidate] (1.177 ms) : 0, 1177
BytebuddyAgent [baseline] (651.652 ms) : 0, 651652
BytebuddyAgent [candidate] (651.368 ms) : 0, 651368
GlobalTracer [baseline] (283.336 ms) : 0, 283336
GlobalTracer [candidate] (283.077 ms) : 0, 283077
AppSec [baseline] (32.698 ms) : 0, 32698
AppSec [candidate] (32.585 ms) : 0, 32585
Debugger [baseline] (67.29 ms) : 0, 67290
Debugger [candidate] (67.67 ms) : 0, 67670
Remote Config [baseline] (681.238 µs) : 0, 681
Remote Config [candidate] (657.829 µs) : 0, 658
Telemetry [baseline] (9.002 ms) : 0, 9002
Telemetry [candidate] (8.963 ms) : 0, 8963
Flare Poller [baseline] (3.793 ms) : 0, 3793
Flare Poller [candidate] (3.744 ms) : 0, 3744
section appsec
crashtracking [baseline] (1.191 ms) : 0, 1191
crashtracking [candidate] (1.183 ms) : 0, 1183
BytebuddyAgent [baseline] (690.543 ms) : 0, 690543
BytebuddyAgent [candidate] (690.984 ms) : 0, 690984
GlobalTracer [baseline] (259.065 ms) : 0, 259065
GlobalTracer [candidate] (259.58 ms) : 0, 259580
IAST [baseline] (24.43 ms) : 0, 24430
IAST [candidate] (24.553 ms) : 0, 24553
AppSec [baseline] (173.605 ms) : 0, 173605
AppSec [candidate] (174.542 ms) : 0, 174542
Debugger [baseline] (68.874 ms) : 0, 68874
Debugger [candidate] (68.261 ms) : 0, 68261
Remote Config [baseline] (787.192 µs) : 0, 787
Remote Config [candidate] (782.929 µs) : 0, 783
Telemetry [baseline] (9.494 ms) : 0, 9494
Telemetry [candidate] (9.481 ms) : 0, 9481
Flare Poller [baseline] (3.735 ms) : 0, 3735
Flare Poller [candidate] (3.797 ms) : 0, 3797
section iast
crashtracking [baseline] (1.19 ms) : 0, 1190
crashtracking [candidate] (1.195 ms) : 0, 1195
BytebuddyAgent [baseline] (791.779 ms) : 0, 791779
BytebuddyAgent [candidate] (799.388 ms) : 0, 799388
GlobalTracer [baseline] (256.628 ms) : 0, 256628
GlobalTracer [candidate] (258.615 ms) : 0, 258615
IAST [baseline] (26.995 ms) : 0, 26995
IAST [candidate] (27.397 ms) : 0, 27397
AppSec [baseline] (32.966 ms) : 0, 32966
AppSec [candidate] (33.665 ms) : 0, 33665
Debugger [baseline] (67.969 ms) : 0, 67969
Debugger [candidate] (66.428 ms) : 0, 66428
Remote Config [baseline] (566.141 µs) : 0, 566
Remote Config [candidate] (607.266 µs) : 0, 607
Telemetry [baseline] (8.403 ms) : 0, 8403
Telemetry [candidate] (8.507 ms) : 0, 8507
Flare Poller [baseline] (3.55 ms) : 0, 3550
Flare Poller [candidate] (3.616 ms) : 0, 3616
section profiling
crashtracking [baseline] (1.261 ms) : 0, 1261
crashtracking [candidate] (1.219 ms) : 0, 1219
BytebuddyAgent [baseline] (712.592 ms) : 0, 712592
BytebuddyAgent [candidate] (702.207 ms) : 0, 702207
GlobalTracer [baseline] (222.523 ms) : 0, 222523
GlobalTracer [candidate] (221.604 ms) : 0, 221604
AppSec [baseline] (32.558 ms) : 0, 32558
AppSec [candidate] (32.035 ms) : 0, 32035
Debugger [baseline] (68.558 ms) : 0, 68558
Debugger [candidate] (68.066 ms) : 0, 68066
Remote Config [baseline] (623.057 µs) : 0, 623
Remote Config [candidate] (638.91 µs) : 0, 639
Telemetry [baseline] (8.88 ms) : 0, 8880
Telemetry [candidate] (9.049 ms) : 0, 9049
Flare Poller [baseline] (3.721 ms) : 0, 3721
Flare Poller [candidate] (3.764 ms) : 0, 3764
ProfilingAgent [baseline] (98.713 ms) : 0, 98713
ProfilingAgent [candidate] (97.905 ms) : 0, 97905
Profiling [baseline] (99.298 ms) : 0, 99298
Profiling [candidate] (98.489 ms) : 0, 98489
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 4 performance regressions! Performance is the same for 14 metrics, 15 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~d08c29d98a, baseline=1.59.0-SNAPSHOT~c072939fa1
dateFormat X
axisFormat %s
section baseline
no_agent (1.2 ms) : 1188, 1211
. : milestone, 1200,
iast (3.251 ms) : 3205, 3296
. : milestone, 3251,
iast_FULL (5.893 ms) : 5834, 5953
. : milestone, 5893,
iast_GLOBAL (3.423 ms) : 3372, 3475
. : milestone, 3423,
profiling (1.939 ms) : 1923, 1956
. : milestone, 1939,
tracing (1.79 ms) : 1773, 1807
. : milestone, 1790,
section candidate
no_agent (1.172 ms) : 1161, 1184
. : milestone, 1172,
iast (3.237 ms) : 3192, 3281
. : milestone, 3237,
iast_FULL (5.786 ms) : 5728, 5843
. : milestone, 5786,
iast_GLOBAL (3.643 ms) : 3583, 3703
. : milestone, 3643,
profiling (2.113 ms) : 2092, 2133
. : milestone, 2113,
tracing (1.778 ms) : 1763, 1792
. : milestone, 1778,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~d08c29d98a, baseline=1.59.0-SNAPSHOT~c072939fa1
dateFormat X
axisFormat %s
section baseline
no_agent (19.553 ms) : 19357, 19749
. : milestone, 19553,
appsec (19.842 ms) : 19631, 20053
. : milestone, 19842,
code_origins (17.961 ms) : 17782, 18141
. : milestone, 17961,
iast (17.757 ms) : 17581, 17933
. : milestone, 17757,
profiling (18.993 ms) : 18799, 19187
. : milestone, 18993,
tracing (17.644 ms) : 17470, 17819
. : milestone, 17644,
section candidate
no_agent (18.238 ms) : 18050, 18427
. : milestone, 18238,
appsec (18.916 ms) : 18722, 19111
. : milestone, 18916,
code_origins (17.655 ms) : 17481, 17829
. : milestone, 17655,
iast (17.795 ms) : 17618, 17972
. : milestone, 17795,
profiling (19.84 ms) : 19632, 20048
. : milestone, 19840,
tracing (17.972 ms) : 17791, 18153
. : milestone, 17972,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 1 unstable metrics.
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~d08c29d98a, baseline=1.59.0-SNAPSHOT~c072939fa1
dateFormat X
axisFormat %s
section baseline
no_agent (1.478 ms) : 1466, 1489
. : milestone, 1478,
appsec (3.732 ms) : 3509, 3954
. : milestone, 3732,
iast (2.213 ms) : 2147, 2278
. : milestone, 2213,
iast_GLOBAL (2.252 ms) : 2186, 2317
. : milestone, 2252,
profiling (2.087 ms) : 2031, 2142
. : milestone, 2087,
tracing (2.042 ms) : 1990, 2094
. : milestone, 2042,
section candidate
no_agent (1.471 ms) : 1459, 1482
. : milestone, 1471,
appsec (2.464 ms) : 2411, 2516
. : milestone, 2464,
iast (2.219 ms) : 2154, 2285
. : milestone, 2219,
iast_GLOBAL (2.254 ms) : 2189, 2320
. : milestone, 2254,
profiling (2.469 ms) : 2309, 2629
. : milestone, 2469,
tracing (2.042 ms) : 1990, 2093
. : milestone, 2042,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~d08c29d98a, baseline=1.59.0-SNAPSHOT~c072939fa1
dateFormat X
axisFormat %s
section baseline
no_agent (15.42 s) : 15420000, 15420000
. : milestone, 15420000,
appsec (15.157 s) : 15157000, 15157000
. : milestone, 15157000,
iast (18.002 s) : 18002000, 18002000
. : milestone, 18002000,
iast_GLOBAL (17.719 s) : 17719000, 17719000
. : milestone, 17719000,
profiling (14.849 s) : 14849000, 14849000
. : milestone, 14849000,
tracing (14.777 s) : 14777000, 14777000
. : milestone, 14777000,
section candidate
no_agent (14.995 s) : 14995000, 14995000
. : milestone, 14995000,
appsec (14.766 s) : 14766000, 14766000
. : milestone, 14766000,
iast (17.944 s) : 17944000, 17944000
. : milestone, 17944000,
iast_GLOBAL (17.651 s) : 17651000, 17651000
. : milestone, 17651000,
profiling (15.457 s) : 15457000, 15457000
. : milestone, 15457000,
tracing (14.621 s) : 14621000, 14621000
. : milestone, 14621000,
|
ygree
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
What Does This Do
Updates Ledger.rest to rest containsRemoval status
In theory, fixes sub-optimal performance when applying a Ledger, but nothing is using Ledger.remove currently
Motivation
Fixes edge case where Ledger doesn't work as expected
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]