-
Notifications
You must be signed in to change notification settings - Fork 324
Fix NullPointerException when scope failure #10333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
If a scope extraction fails extract method can return null. need to add a check against null at call sire
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 6 unstable metrics. See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (341.459 µs) : 294, 389
. : milestone, 341,
basic (289.804 µs) : 281, 299
. : milestone, 290,
loop (8.961 ms) : 8953, 8968
. : milestone, 8961,
section candidate
noprobe (329.64 µs) : 301, 358
. : milestone, 330,
basic (281.724 µs) : 274, 290
. : milestone, 282,
loop (8.973 ms) : 8965, 8980
. : milestone, 8973,
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 61 metrics, 4 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~cb6b12f992, baseline=1.59.0-SNAPSHOT~d184301c7c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.081 s) : 0, 1080664
Total [baseline] (8.742 s) : 0, 8741811
Agent [candidate] (1.085 s) : 0, 1085308
Total [candidate] (8.713 s) : 0, 8712713
section iast
Agent [baseline] (1.221 s) : 0, 1221024
Total [baseline] (9.276 s) : 0, 9275584
Agent [candidate] (1.229 s) : 0, 1229074
Total [candidate] (9.305 s) : 0, 9304922
gantt
title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~cb6b12f992, baseline=1.59.0-SNAPSHOT~d184301c7c
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.178 ms) : 0, 1178
crashtracking [candidate] (1.182 ms) : 0, 1182
BytebuddyAgent [baseline] (649.355 ms) : 0, 649355
BytebuddyAgent [candidate] (650.731 ms) : 0, 650731
GlobalTracer [baseline] (281.829 ms) : 0, 281829
GlobalTracer [candidate] (284.508 ms) : 0, 284508
AppSec [baseline] (32.418 ms) : 0, 32418
AppSec [candidate] (32.889 ms) : 0, 32889
Debugger [baseline] (67.081 ms) : 0, 67081
Debugger [candidate] (67.262 ms) : 0, 67262
Remote Config [baseline] (629.163 µs) : 0, 629
Remote Config [candidate] (607.172 µs) : 0, 607
Telemetry [baseline] (9.0 ms) : 0, 9000
Telemetry [candidate] (8.998 ms) : 0, 8998
Flare Poller [baseline] (3.712 ms) : 0, 3712
Flare Poller [candidate] (3.722 ms) : 0, 3722
section iast
crashtracking [baseline] (1.178 ms) : 0, 1178
crashtracking [candidate] (1.186 ms) : 0, 1186
BytebuddyAgent [baseline] (789.719 ms) : 0, 789719
BytebuddyAgent [candidate] (795.586 ms) : 0, 795586
GlobalTracer [baseline] (255.506 ms) : 0, 255506
GlobalTracer [candidate] (257.049 ms) : 0, 257049
AppSec [baseline] (35.296 ms) : 0, 35296
AppSec [candidate] (35.27 ms) : 0, 35270
Debugger [baseline] (64.08 ms) : 0, 64080
Debugger [candidate] (64.734 ms) : 0, 64734
Remote Config [baseline] (601.362 µs) : 0, 601
Remote Config [candidate] (627.386 µs) : 0, 627
Telemetry [baseline] (8.527 ms) : 0, 8527
Telemetry [candidate] (8.486 ms) : 0, 8486
Flare Poller [baseline] (3.567 ms) : 0, 3567
Flare Poller [candidate] (3.546 ms) : 0, 3546
IAST [baseline] (27.204 ms) : 0, 27204
IAST [candidate] (27.196 ms) : 0, 27196
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~cb6b12f992, baseline=1.59.0-SNAPSHOT~d184301c7c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.093 s) : 0, 1092629
Total [baseline] (10.9 s) : 0, 10899542
Agent [candidate] (1.091 s) : 0, 1090889
Total [candidate] (10.843 s) : 0, 10843307
section appsec
Agent [baseline] (1.265 s) : 0, 1264829
Total [baseline] (10.92 s) : 0, 10919749
Agent [candidate] (1.264 s) : 0, 1264034
Total [candidate] (11.009 s) : 0, 11009090
section iast
Agent [baseline] (1.225 s) : 0, 1224537
Total [baseline] (11.13 s) : 0, 11129979
Agent [candidate] (1.221 s) : 0, 1221014
Total [candidate] (11.217 s) : 0, 11217108
section profiling
Agent [baseline] (1.212 s) : 0, 1211782
Total [baseline] (10.919 s) : 0, 10919175
Agent [candidate] (1.212 s) : 0, 1211750
Total [candidate] (10.957 s) : 0, 10957129
gantt
title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~cb6b12f992, baseline=1.59.0-SNAPSHOT~d184301c7c
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.188 ms) : 0, 1188
crashtracking [candidate] (1.182 ms) : 0, 1182
BytebuddyAgent [baseline] (655.822 ms) : 0, 655822
BytebuddyAgent [candidate] (654.691 ms) : 0, 654691
GlobalTracer [baseline] (284.676 ms) : 0, 284676
GlobalTracer [candidate] (283.975 ms) : 0, 283975
AppSec [baseline] (32.834 ms) : 0, 32834
AppSec [candidate] (33.038 ms) : 0, 33038
Debugger [baseline] (68.747 ms) : 0, 68747
Debugger [candidate] (68.899 ms) : 0, 68899
Remote Config [baseline] (648.402 µs) : 0, 648
Remote Config [candidate] (630.042 µs) : 0, 630
Telemetry [baseline] (9.207 ms) : 0, 9207
Telemetry [candidate] (9.127 ms) : 0, 9127
Flare Poller [baseline] (3.793 ms) : 0, 3793
Flare Poller [candidate] (3.783 ms) : 0, 3783
section appsec
crashtracking [baseline] (1.176 ms) : 0, 1176
crashtracking [candidate] (1.18 ms) : 0, 1180
BytebuddyAgent [baseline] (690.185 ms) : 0, 690185
BytebuddyAgent [candidate] (690.596 ms) : 0, 690596
GlobalTracer [baseline] (258.314 ms) : 0, 258314
GlobalTracer [candidate] (258.513 ms) : 0, 258513
AppSec [baseline] (173.644 ms) : 0, 173644
AppSec [candidate] (173.654 ms) : 0, 173654
Debugger [baseline] (67.342 ms) : 0, 67342
Debugger [candidate] (66.393 ms) : 0, 66393
Remote Config [baseline] (740.392 µs) : 0, 740
Remote Config [candidate] (769.953 µs) : 0, 770
Telemetry [baseline] (9.451 ms) : 0, 9451
Telemetry [candidate] (9.281 ms) : 0, 9281
Flare Poller [baseline] (3.839 ms) : 0, 3839
Flare Poller [candidate] (3.689 ms) : 0, 3689
IAST [baseline] (24.693 ms) : 0, 24693
IAST [candidate] (24.557 ms) : 0, 24557
section iast
crashtracking [baseline] (1.189 ms) : 0, 1189
crashtracking [candidate] (1.181 ms) : 0, 1181
BytebuddyAgent [baseline] (791.173 ms) : 0, 791173
BytebuddyAgent [candidate] (789.548 ms) : 0, 789548
GlobalTracer [baseline] (255.768 ms) : 0, 255768
GlobalTracer [candidate] (255.017 ms) : 0, 255017
AppSec [baseline] (33.767 ms) : 0, 33767
AppSec [candidate] (35.105 ms) : 0, 35105
Debugger [baseline] (67.394 ms) : 0, 67394
Debugger [candidate] (65.081 ms) : 0, 65081
Remote Config [baseline] (635.913 µs) : 0, 636
Remote Config [candidate] (630.714 µs) : 0, 631
Telemetry [baseline] (8.692 ms) : 0, 8692
Telemetry [candidate] (8.571 ms) : 0, 8571
Flare Poller [baseline] (3.588 ms) : 0, 3588
Flare Poller [candidate] (3.612 ms) : 0, 3612
IAST [baseline] (26.931 ms) : 0, 26931
IAST [candidate] (27.017 ms) : 0, 27017
section profiling
crashtracking [baseline] (1.219 ms) : 0, 1219
crashtracking [candidate] (1.221 ms) : 0, 1221
BytebuddyAgent [baseline] (706.525 ms) : 0, 706525
BytebuddyAgent [candidate] (707.24 ms) : 0, 707240
GlobalTracer [baseline] (222.018 ms) : 0, 222018
GlobalTracer [candidate] (221.826 ms) : 0, 221826
AppSec [baseline] (32.642 ms) : 0, 32642
AppSec [candidate] (32.529 ms) : 0, 32529
Debugger [baseline] (68.626 ms) : 0, 68626
Debugger [candidate] (68.513 ms) : 0, 68513
Remote Config [baseline] (660.229 µs) : 0, 660
Remote Config [candidate] (643.482 µs) : 0, 643
Telemetry [baseline] (8.919 ms) : 0, 8919
Telemetry [candidate] (8.775 ms) : 0, 8775
Flare Poller [baseline] (3.747 ms) : 0, 3747
Flare Poller [candidate] (3.656 ms) : 0, 3656
ProfilingAgent [baseline] (97.232 ms) : 0, 97232
ProfilingAgent [candidate] (97.2 ms) : 0, 97200
Profiling [baseline] (97.816 ms) : 0, 97816
Profiling [candidate] (97.792 ms) : 0, 97792
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 2 performance regressions! Performance is the same for 17 metrics, 17 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~cb6b12f992, baseline=1.59.0-SNAPSHOT~d184301c7c
dateFormat X
axisFormat %s
section baseline
no_agent (1.185 ms) : 1173, 1197
. : milestone, 1185,
iast (3.19 ms) : 3154, 3227
. : milestone, 3190,
iast_FULL (5.835 ms) : 5777, 5893
. : milestone, 5835,
iast_GLOBAL (3.491 ms) : 3444, 3538
. : milestone, 3491,
profiling (2.052 ms) : 2033, 2071
. : milestone, 2052,
tracing (1.752 ms) : 1738, 1766
. : milestone, 1752,
section candidate
no_agent (1.192 ms) : 1180, 1204
. : milestone, 1192,
iast (3.249 ms) : 3202, 3296
. : milestone, 3249,
iast_FULL (5.985 ms) : 5924, 6046
. : milestone, 5985,
iast_GLOBAL (3.585 ms) : 3532, 3637
. : milestone, 3585,
profiling (2.07 ms) : 2052, 2088
. : milestone, 2070,
tracing (1.803 ms) : 1788, 1818
. : milestone, 1803,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~cb6b12f992, baseline=1.59.0-SNAPSHOT~d184301c7c
dateFormat X
axisFormat %s
section baseline
no_agent (18.386 ms) : 18199, 18574
. : milestone, 18386,
appsec (18.725 ms) : 18533, 18918
. : milestone, 18725,
code_origins (17.693 ms) : 17516, 17871
. : milestone, 17693,
iast (17.784 ms) : 17606, 17962
. : milestone, 17784,
profiling (18.721 ms) : 18531, 18911
. : milestone, 18721,
tracing (17.735 ms) : 17559, 17911
. : milestone, 17735,
section candidate
no_agent (18.062 ms) : 17877, 18246
. : milestone, 18062,
appsec (18.734 ms) : 18545, 18923
. : milestone, 18734,
code_origins (18.426 ms) : 18241, 18611
. : milestone, 18426,
iast (17.686 ms) : 17510, 17862
. : milestone, 17686,
profiling (19.513 ms) : 19318, 19709
. : milestone, 19513,
tracing (17.86 ms) : 17679, 18041
. : milestone, 17860,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~cb6b12f992, baseline=1.59.0-SNAPSHOT~d184301c7c
dateFormat X
axisFormat %s
section baseline
no_agent (14.923 s) : 14923000, 14923000
. : milestone, 14923000,
appsec (14.502 s) : 14502000, 14502000
. : milestone, 14502000,
iast (18.252 s) : 18252000, 18252000
. : milestone, 18252000,
iast_GLOBAL (17.411 s) : 17411000, 17411000
. : milestone, 17411000,
profiling (15.393 s) : 15393000, 15393000
. : milestone, 15393000,
tracing (14.84 s) : 14840000, 14840000
. : milestone, 14840000,
section candidate
no_agent (15.618 s) : 15618000, 15618000
. : milestone, 15618000,
appsec (14.638 s) : 14638000, 14638000
. : milestone, 14638000,
iast (17.829 s) : 17829000, 17829000
. : milestone, 17829000,
iast_GLOBAL (17.653 s) : 17653000, 17653000
. : milestone, 17653000,
profiling (14.945 s) : 14945000, 14945000
. : milestone, 14945000,
tracing (14.84 s) : 14840000, 14840000
. : milestone, 14840000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~cb6b12f992, baseline=1.59.0-SNAPSHOT~d184301c7c
dateFormat X
axisFormat %s
section baseline
no_agent (1.474 ms) : 1462, 1485
. : milestone, 1474,
appsec (3.707 ms) : 3487, 3926
. : milestone, 3707,
iast (2.209 ms) : 2144, 2274
. : milestone, 2209,
iast_GLOBAL (2.261 ms) : 2195, 2327
. : milestone, 2261,
profiling (2.088 ms) : 2034, 2143
. : milestone, 2088,
tracing (2.045 ms) : 1994, 2097
. : milestone, 2045,
section candidate
no_agent (1.478 ms) : 1466, 1490
. : milestone, 1478,
appsec (3.705 ms) : 3486, 3925
. : milestone, 3705,
iast (2.218 ms) : 2153, 2283
. : milestone, 2218,
iast_GLOBAL (2.26 ms) : 2194, 2325
. : milestone, 2260,
profiling (2.075 ms) : 2022, 2129
. : milestone, 2075,
tracing (2.055 ms) : 2004, 2107
. : milestone, 2055,
|
dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/symbol/SymbolAggregator.java
Show resolved
Hide resolved
| loadedClasses.put(fqn, 1); | ||
| } | ||
| LOGGER.debug("Extracting Symbols from: {}, located in: {}", className, jarName); | ||
| Scope jarScope = SymbolExtractor.extract(classfileBuffer, jarName); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please document the extract method saying that it swallows exceptions and returns null
What Does This Do
If a scope extraction fails extract method can return null. need to add a check against null at call sire
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: DEBUG-4942