-
Notifications
You must be signed in to change notification settings - Fork 324
Cleanup unnecessary semicolons. #10321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jpbempel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for debugger part
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 6 unstable metrics. See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (354.303 µs) : 254, 455
. : milestone, 354,
basic (279.042 µs) : 271, 287
. : milestone, 279,
loop (8.95 ms) : 8944, 8956
. : milestone, 8950,
section candidate
noprobe (312.205 µs) : 282, 343
. : milestone, 312,
basic (274.527 µs) : 269, 280
. : milestone, 275,
loop (8.949 ms) : 8944, 8955
. : milestone, 8949,
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 8 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~690b3f8f6d, baseline=1.59.0-SNAPSHOT~02a76b1548
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.086 s) : 0, 1085965
Total [baseline] (10.832 s) : 0, 10832373
Agent [candidate] (1.087 s) : 0, 1087245
Total [candidate] (10.767 s) : 0, 10766638
section appsec
Agent [baseline] (1.278 s) : 0, 1277724
Total [baseline] (11.002 s) : 0, 11002463
Agent [candidate] (1.269 s) : 0, 1268671
Total [candidate] (10.946 s) : 0, 10946308
section iast
Agent [baseline] (1.225 s) : 0, 1225108
Total [baseline] (11.126 s) : 0, 11125847
Agent [candidate] (1.236 s) : 0, 1236222
Total [candidate] (11.319 s) : 0, 11318873
section profiling
Agent [baseline] (1.205 s) : 0, 1204802
Total [baseline] (10.923 s) : 0, 10922622
Agent [candidate] (1.205 s) : 0, 1205483
Total [candidate] (10.907 s) : 0, 10907120
gantt
title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~690b3f8f6d, baseline=1.59.0-SNAPSHOT~02a76b1548
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.184 ms) : 0, 1184
crashtracking [candidate] (1.191 ms) : 0, 1191
BytebuddyAgent [baseline] (652.104 ms) : 0, 652104
BytebuddyAgent [candidate] (653.29 ms) : 0, 653290
GlobalTracer [baseline] (282.126 ms) : 0, 282126
GlobalTracer [candidate] (282.813 ms) : 0, 282813
AppSec [baseline] (32.585 ms) : 0, 32585
AppSec [candidate] (32.766 ms) : 0, 32766
Debugger [baseline] (68.857 ms) : 0, 68857
Debugger [candidate] (68.369 ms) : 0, 68369
Remote Config [baseline] (633.679 µs) : 0, 634
Remote Config [candidate] (636.675 µs) : 0, 637
Telemetry [baseline] (9.146 ms) : 0, 9146
Telemetry [candidate] (8.914 ms) : 0, 8914
Flare Poller [baseline] (3.812 ms) : 0, 3812
Flare Poller [candidate] (3.718 ms) : 0, 3718
section appsec
crashtracking [baseline] (1.195 ms) : 0, 1195
crashtracking [candidate] (1.184 ms) : 0, 1184
BytebuddyAgent [baseline] (698.946 ms) : 0, 698946
BytebuddyAgent [candidate] (692.912 ms) : 0, 692912
GlobalTracer [baseline] (260.604 ms) : 0, 260604
GlobalTracer [candidate] (259.192 ms) : 0, 259192
IAST [baseline] (24.993 ms) : 0, 24993
IAST [candidate] (24.714 ms) : 0, 24714
AppSec [baseline] (173.988 ms) : 0, 173988
AppSec [candidate] (173.937 ms) : 0, 173937
Debugger [baseline] (68.138 ms) : 0, 68138
Debugger [candidate] (67.496 ms) : 0, 67496
Remote Config [baseline] (743.873 µs) : 0, 744
Remote Config [candidate] (717.97 µs) : 0, 718
Telemetry [baseline] (9.588 ms) : 0, 9588
Telemetry [candidate] (9.334 ms) : 0, 9334
Flare Poller [baseline] (3.832 ms) : 0, 3832
Flare Poller [candidate] (3.773 ms) : 0, 3773
section iast
crashtracking [baseline] (1.187 ms) : 0, 1187
crashtracking [candidate] (1.194 ms) : 0, 1194
BytebuddyAgent [baseline] (792.17 ms) : 0, 792170
BytebuddyAgent [candidate] (798.92 ms) : 0, 798920
GlobalTracer [baseline] (256.056 ms) : 0, 256056
GlobalTracer [candidate] (258.193 ms) : 0, 258193
IAST [baseline] (27.049 ms) : 0, 27049
IAST [candidate] (27.452 ms) : 0, 27452
AppSec [baseline] (33.904 ms) : 0, 33904
AppSec [candidate] (33.954 ms) : 0, 33954
Debugger [baseline] (66.631 ms) : 0, 66631
Debugger [candidate] (67.908 ms) : 0, 67908
Remote Config [baseline] (583.547 µs) : 0, 584
Remote Config [candidate] (605.336 µs) : 0, 605
Telemetry [baseline] (8.509 ms) : 0, 8509
Telemetry [candidate] (8.727 ms) : 0, 8727
Flare Poller [baseline] (3.565 ms) : 0, 3565
Flare Poller [candidate] (3.646 ms) : 0, 3646
section profiling
crashtracking [baseline] (1.217 ms) : 0, 1217
crashtracking [candidate] (1.21 ms) : 0, 1210
BytebuddyAgent [baseline] (702.55 ms) : 0, 702550
BytebuddyAgent [candidate] (702.868 ms) : 0, 702868
GlobalTracer [baseline] (220.793 ms) : 0, 220793
GlobalTracer [candidate] (220.638 ms) : 0, 220638
AppSec [baseline] (32.076 ms) : 0, 32076
AppSec [candidate] (32.111 ms) : 0, 32111
Debugger [baseline] (68.144 ms) : 0, 68144
Debugger [candidate] (68.419 ms) : 0, 68419
Remote Config [baseline] (630.767 µs) : 0, 631
Remote Config [candidate] (621.394 µs) : 0, 621
Telemetry [baseline] (8.729 ms) : 0, 8729
Telemetry [candidate] (8.806 ms) : 0, 8806
Flare Poller [baseline] (3.666 ms) : 0, 3666
Flare Poller [candidate] (3.654 ms) : 0, 3654
ProfilingAgent [baseline] (97.112 ms) : 0, 97112
ProfilingAgent [candidate] (97.311 ms) : 0, 97311
Profiling [baseline] (97.684 ms) : 0, 97684
Profiling [candidate] (97.888 ms) : 0, 97888
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~690b3f8f6d, baseline=1.59.0-SNAPSHOT~02a76b1548
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.086 s) : 0, 1086413
Total [baseline] (8.736 s) : 0, 8736048
Agent [candidate] (1.085 s) : 0, 1085176
Total [candidate] (8.75 s) : 0, 8749534
section iast
Agent [baseline] (1.223 s) : 0, 1222769
Total [baseline] (9.372 s) : 0, 9371890
Agent [candidate] (1.224 s) : 0, 1223728
Total [candidate] (9.31 s) : 0, 9310363
gantt
title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~690b3f8f6d, baseline=1.59.0-SNAPSHOT~02a76b1548
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.19 ms) : 0, 1190
crashtracking [candidate] (1.183 ms) : 0, 1183
BytebuddyAgent [baseline] (653.479 ms) : 0, 653479
BytebuddyAgent [candidate] (652.085 ms) : 0, 652085
GlobalTracer [baseline] (282.568 ms) : 0, 282568
GlobalTracer [candidate] (282.674 ms) : 0, 282674
AppSec [baseline] (32.631 ms) : 0, 32631
AppSec [candidate] (32.698 ms) : 0, 32698
Debugger [baseline] (67.559 ms) : 0, 67559
Debugger [candidate] (67.709 ms) : 0, 67709
Remote Config [baseline] (626.185 µs) : 0, 626
Remote Config [candidate] (626.68 µs) : 0, 627
Telemetry [baseline] (9.022 ms) : 0, 9022
Telemetry [candidate] (8.956 ms) : 0, 8956
Flare Poller [baseline] (3.731 ms) : 0, 3731
Flare Poller [candidate] (3.721 ms) : 0, 3721
section iast
crashtracking [baseline] (1.181 ms) : 0, 1181
crashtracking [candidate] (1.179 ms) : 0, 1179
BytebuddyAgent [baseline] (791.205 ms) : 0, 791205
BytebuddyAgent [candidate] (792.061 ms) : 0, 792061
GlobalTracer [baseline] (255.593 ms) : 0, 255593
GlobalTracer [candidate] (256.121 ms) : 0, 256121
AppSec [baseline] (34.434 ms) : 0, 34434
AppSec [candidate] (33.428 ms) : 0, 33428
Debugger [baseline] (65.085 ms) : 0, 65085
Debugger [candidate] (65.919 ms) : 0, 65919
Remote Config [baseline] (595.035 µs) : 0, 595
Remote Config [candidate] (582.452 µs) : 0, 582
Telemetry [baseline] (8.562 ms) : 0, 8562
Telemetry [candidate] (8.477 ms) : 0, 8477
Flare Poller [baseline] (3.581 ms) : 0, 3581
Flare Poller [candidate] (3.511 ms) : 0, 3511
IAST [baseline] (27.095 ms) : 0, 27095
IAST [candidate] (26.973 ms) : 0, 26973
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 0 performance regressions! Performance is the same for 19 metrics, 15 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~690b3f8f6d, baseline=1.59.0-SNAPSHOT~02a76b1548
dateFormat X
axisFormat %s
section baseline
no_agent (19.325 ms) : 19129, 19522
. : milestone, 19325,
appsec (18.936 ms) : 18747, 19126
. : milestone, 18936,
code_origins (17.651 ms) : 17478, 17825
. : milestone, 17651,
iast (17.462 ms) : 17288, 17636
. : milestone, 17462,
profiling (18.442 ms) : 18260, 18625
. : milestone, 18442,
tracing (17.215 ms) : 17045, 17384
. : milestone, 17215,
section candidate
no_agent (17.194 ms) : 17021, 17366
. : milestone, 17194,
appsec (18.684 ms) : 18494, 18874
. : milestone, 18684,
code_origins (17.706 ms) : 17530, 17882
. : milestone, 17706,
iast (17.802 ms) : 17624, 17980
. : milestone, 17802,
profiling (18.588 ms) : 18401, 18776
. : milestone, 18588,
tracing (17.41 ms) : 17237, 17583
. : milestone, 17410,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~690b3f8f6d, baseline=1.59.0-SNAPSHOT~02a76b1548
dateFormat X
axisFormat %s
section baseline
no_agent (1.196 ms) : 1184, 1208
. : milestone, 1196,
iast (3.044 ms) : 3009, 3079
. : milestone, 3044,
iast_FULL (5.703 ms) : 5648, 5759
. : milestone, 5703,
iast_GLOBAL (3.572 ms) : 3516, 3628
. : milestone, 3572,
profiling (1.87 ms) : 1855, 1886
. : milestone, 1870,
tracing (1.774 ms) : 1760, 1789
. : milestone, 1774,
section candidate
no_agent (1.204 ms) : 1192, 1216
. : milestone, 1204,
iast (3.15 ms) : 3112, 3188
. : milestone, 3150,
iast_FULL (5.757 ms) : 5699, 5814
. : milestone, 5757,
iast_GLOBAL (3.486 ms) : 3435, 3538
. : milestone, 3486,
profiling (1.966 ms) : 1949, 1982
. : milestone, 1966,
tracing (1.752 ms) : 1738, 1766
. : milestone, 1752,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~690b3f8f6d, baseline=1.59.0-SNAPSHOT~02a76b1548
dateFormat X
axisFormat %s
section baseline
no_agent (1.482 ms) : 1470, 1493
. : milestone, 1482,
appsec (3.757 ms) : 3537, 3978
. : milestone, 3757,
iast (2.226 ms) : 2161, 2290
. : milestone, 2226,
iast_GLOBAL (2.269 ms) : 2204, 2333
. : milestone, 2269,
profiling (2.077 ms) : 2025, 2130
. : milestone, 2077,
tracing (2.06 ms) : 2008, 2111
. : milestone, 2060,
section candidate
no_agent (1.479 ms) : 1468, 1491
. : milestone, 1479,
appsec (3.751 ms) : 3530, 3972
. : milestone, 3751,
iast (2.216 ms) : 2152, 2281
. : milestone, 2216,
iast_GLOBAL (2.268 ms) : 2203, 2334
. : milestone, 2268,
profiling (2.084 ms) : 2031, 2137
. : milestone, 2084,
tracing (2.055 ms) : 2004, 2106
. : milestone, 2055,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~690b3f8f6d, baseline=1.59.0-SNAPSHOT~02a76b1548
dateFormat X
axisFormat %s
section baseline
no_agent (14.806 s) : 14806000, 14806000
. : milestone, 14806000,
appsec (14.493 s) : 14493000, 14493000
. : milestone, 14493000,
iast (18.276 s) : 18276000, 18276000
. : milestone, 18276000,
iast_GLOBAL (17.689 s) : 17689000, 17689000
. : milestone, 17689000,
profiling (14.921 s) : 14921000, 14921000
. : milestone, 14921000,
tracing (14.686 s) : 14686000, 14686000
. : milestone, 14686000,
section candidate
no_agent (15.72 s) : 15720000, 15720000
. : milestone, 15720000,
appsec (14.61 s) : 14610000, 14610000
. : milestone, 14610000,
iast (18.407 s) : 18407000, 18407000
. : milestone, 18407000,
iast_GLOBAL (17.888 s) : 17888000, 17888000
. : milestone, 17888000,
profiling (14.727 s) : 14727000, 14727000
. : milestone, 14727000,
tracing (14.638 s) : 14638000, 14638000
. : milestone, 14638000,
|
What Does This Do
Cleanup unnecessary semicolons.
Motivation
Clean code.
Additional Notes
Found by IDEA static analysis.