-
Notifications
You must be signed in to change notification settings - Fork 324
Enabling optimized map by default #10016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 11 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~1287c94bb7, baseline=1.59.0-SNAPSHOT~645ed325fc
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.084 s) : 0, 1083973
Total [baseline] (10.772 s) : 0, 10772330
Agent [candidate] (1.091 s) : 0, 1091033
Total [candidate] (10.92 s) : 0, 10919849
section appsec
Agent [baseline] (1.268 s) : 0, 1268135
Total [baseline] (11.053 s) : 0, 11052797
Agent [candidate] (1.269 s) : 0, 1268762
Total [candidate] (11.046 s) : 0, 11045804
section iast
Agent [baseline] (1.227 s) : 0, 1227169
Total [baseline] (11.226 s) : 0, 11225828
Agent [candidate] (1.232 s) : 0, 1231561
Total [candidate] (11.132 s) : 0, 11131687
section profiling
Agent [baseline] (1.214 s) : 0, 1213515
Total [baseline] (11.008 s) : 0, 11008096
Agent [candidate] (1.207 s) : 0, 1206512
Total [candidate] (10.955 s) : 0, 10955315
gantt
title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~1287c94bb7, baseline=1.59.0-SNAPSHOT~645ed325fc
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.183 ms) : 0, 1183
crashtracking [candidate] (1.198 ms) : 0, 1198
BytebuddyAgent [baseline] (650.634 ms) : 0, 650634
BytebuddyAgent [candidate] (654.993 ms) : 0, 654993
GlobalTracer [baseline] (282.585 ms) : 0, 282585
GlobalTracer [candidate] (284.646 ms) : 0, 284646
AppSec [baseline] (32.417 ms) : 0, 32417
AppSec [candidate] (32.932 ms) : 0, 32932
Debugger [baseline] (68.081 ms) : 0, 68081
Debugger [candidate] (67.396 ms) : 0, 67396
Remote Config [baseline] (668.155 µs) : 0, 668
Remote Config [candidate] (655.708 µs) : 0, 656
Telemetry [baseline] (8.978 ms) : 0, 8978
Telemetry [candidate] (8.945 ms) : 0, 8945
Flare Poller [baseline] (3.794 ms) : 0, 3794
Flare Poller [candidate] (4.542 ms) : 0, 4542
section appsec
crashtracking [baseline] (1.189 ms) : 0, 1189
crashtracking [candidate] (1.191 ms) : 0, 1191
BytebuddyAgent [baseline] (691.605 ms) : 0, 691605
BytebuddyAgent [candidate] (691.509 ms) : 0, 691509
GlobalTracer [baseline] (258.937 ms) : 0, 258937
GlobalTracer [candidate] (259.75 ms) : 0, 259750
IAST [baseline] (24.559 ms) : 0, 24559
IAST [candidate] (24.513 ms) : 0, 24513
AppSec [baseline] (173.604 ms) : 0, 173604
AppSec [candidate] (174.309 ms) : 0, 174309
Debugger [baseline] (68.547 ms) : 0, 68547
Debugger [candidate] (68.025 ms) : 0, 68025
Remote Config [baseline] (787.906 µs) : 0, 788
Remote Config [candidate] (800.799 µs) : 0, 801
Telemetry [baseline] (9.512 ms) : 0, 9512
Telemetry [candidate] (9.368 ms) : 0, 9368
Flare Poller [baseline] (3.867 ms) : 0, 3867
Flare Poller [candidate] (3.778 ms) : 0, 3778
section iast
crashtracking [baseline] (1.205 ms) : 0, 1205
crashtracking [candidate] (1.202 ms) : 0, 1202
BytebuddyAgent [baseline] (793.699 ms) : 0, 793699
BytebuddyAgent [candidate] (795.877 ms) : 0, 795877
GlobalTracer [baseline] (256.819 ms) : 0, 256819
GlobalTracer [candidate] (258.117 ms) : 0, 258117
IAST [baseline] (26.99 ms) : 0, 26990
IAST [candidate] (27.207 ms) : 0, 27207
AppSec [baseline] (35.696 ms) : 0, 35696
AppSec [candidate] (33.034 ms) : 0, 33034
Debugger [baseline] (64.674 ms) : 0, 64674
Debugger [candidate] (67.697 ms) : 0, 67697
Remote Config [baseline] (574.107 µs) : 0, 574
Remote Config [candidate] (560.275 µs) : 0, 560
Telemetry [baseline] (8.468 ms) : 0, 8468
Telemetry [candidate] (8.568 ms) : 0, 8568
Flare Poller [baseline] (3.564 ms) : 0, 3564
Flare Poller [candidate] (3.601 ms) : 0, 3601
section profiling
crashtracking [baseline] (1.228 ms) : 0, 1228
crashtracking [candidate] (1.221 ms) : 0, 1221
BytebuddyAgent [baseline] (706.01 ms) : 0, 706010
BytebuddyAgent [candidate] (703.041 ms) : 0, 703041
GlobalTracer [baseline] (222.014 ms) : 0, 222014
GlobalTracer [candidate] (221.304 ms) : 0, 221304
AppSec [baseline] (32.659 ms) : 0, 32659
AppSec [candidate] (32.082 ms) : 0, 32082
Debugger [baseline] (68.751 ms) : 0, 68751
Debugger [candidate] (68.657 ms) : 0, 68657
Remote Config [baseline] (658.675 µs) : 0, 659
Remote Config [candidate] (647.168 µs) : 0, 647
Telemetry [baseline] (9.039 ms) : 0, 9039
Telemetry [candidate] (8.93 ms) : 0, 8930
Flare Poller [baseline] (3.802 ms) : 0, 3802
Flare Poller [candidate] (3.779 ms) : 0, 3779
ProfilingAgent [baseline] (99.055 ms) : 0, 99055
ProfilingAgent [candidate] (96.855 ms) : 0, 96855
Profiling [baseline] (99.648 ms) : 0, 99648
Profiling [candidate] (97.43 ms) : 0, 97430
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~1287c94bb7, baseline=1.59.0-SNAPSHOT~645ed325fc
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.094 s) : 0, 1094463
Total [baseline] (8.773 s) : 0, 8772937
Agent [candidate] (1.087 s) : 0, 1086554
Total [candidate] (8.751 s) : 0, 8751257
section iast
Agent [baseline] (1.236 s) : 0, 1235685
Total [baseline] (9.343 s) : 0, 9342962
Agent [candidate] (1.227 s) : 0, 1226804
Total [candidate] (9.336 s) : 0, 9336056
gantt
title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~1287c94bb7, baseline=1.59.0-SNAPSHOT~645ed325fc
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.199 ms) : 0, 1199
crashtracking [candidate] (1.19 ms) : 0, 1190
BytebuddyAgent [baseline] (657.617 ms) : 0, 657617
BytebuddyAgent [candidate] (652.259 ms) : 0, 652259
GlobalTracer [baseline] (285.316 ms) : 0, 285316
GlobalTracer [candidate] (283.593 ms) : 0, 283593
AppSec [baseline] (33.091 ms) : 0, 33091
AppSec [candidate] (32.841 ms) : 0, 32841
Debugger [baseline] (66.929 ms) : 0, 66929
Debugger [candidate] (67.708 ms) : 0, 67708
Remote Config [baseline] (683.362 µs) : 0, 683
Remote Config [candidate] (650.978 µs) : 0, 651
Telemetry [baseline] (9.063 ms) : 0, 9063
Telemetry [candidate] (8.947 ms) : 0, 8947
Flare Poller [baseline] (4.725 ms) : 0, 4725
Flare Poller [candidate] (3.735 ms) : 0, 3735
section iast
crashtracking [baseline] (1.211 ms) : 0, 1211
crashtracking [candidate] (1.192 ms) : 0, 1192
BytebuddyAgent [baseline] (800.707 ms) : 0, 800707
BytebuddyAgent [candidate] (793.552 ms) : 0, 793552
GlobalTracer [baseline] (257.955 ms) : 0, 257955
GlobalTracer [candidate] (257.036 ms) : 0, 257036
IAST [baseline] (27.226 ms) : 0, 27226
IAST [candidate] (27.101 ms) : 0, 27101
AppSec [baseline] (34.447 ms) : 0, 34447
AppSec [candidate] (33.635 ms) : 0, 33635
Debugger [baseline] (65.625 ms) : 0, 65625
Debugger [candidate] (66.083 ms) : 0, 66083
Remote Config [baseline] (606.697 µs) : 0, 607
Remote Config [candidate] (616.501 µs) : 0, 617
Telemetry [baseline] (8.437 ms) : 0, 8437
Telemetry [candidate] (8.467 ms) : 0, 8467
Flare Poller [baseline] (3.6 ms) : 0, 3600
Flare Poller [candidate] (3.572 ms) : 0, 3572
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 0 performance regressions! Performance is the same for 18 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~1287c94bb7, baseline=1.59.0-SNAPSHOT~645ed325fc
dateFormat X
axisFormat %s
section baseline
no_agent (17.919 ms) : 17737, 18101
. : milestone, 17919,
appsec (18.251 ms) : 18066, 18437
. : milestone, 18251,
code_origins (17.775 ms) : 17598, 17952
. : milestone, 17775,
iast (17.977 ms) : 17799, 18154
. : milestone, 17977,
profiling (19.008 ms) : 18813, 19202
. : milestone, 19008,
tracing (17.734 ms) : 17557, 17912
. : milestone, 17734,
section candidate
no_agent (17.832 ms) : 17653, 18011
. : milestone, 17832,
appsec (18.373 ms) : 18189, 18556
. : milestone, 18373,
code_origins (17.76 ms) : 17586, 17934
. : milestone, 17760,
iast (17.867 ms) : 17687, 18047
. : milestone, 17867,
profiling (18.354 ms) : 18170, 18539
. : milestone, 18354,
tracing (17.69 ms) : 17514, 17865
. : milestone, 17690,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~1287c94bb7, baseline=1.59.0-SNAPSHOT~645ed325fc
dateFormat X
axisFormat %s
section baseline
no_agent (1.175 ms) : 1164, 1186
. : milestone, 1175,
iast (3.249 ms) : 3200, 3297
. : milestone, 3249,
iast_FULL (5.853 ms) : 5794, 5912
. : milestone, 5853,
iast_GLOBAL (3.644 ms) : 3587, 3701
. : milestone, 3644,
profiling (2.062 ms) : 2042, 2082
. : milestone, 2062,
tracing (1.808 ms) : 1792, 1824
. : milestone, 1808,
section candidate
no_agent (1.196 ms) : 1185, 1208
. : milestone, 1196,
iast (3.257 ms) : 3211, 3302
. : milestone, 3257,
iast_FULL (5.653 ms) : 5598, 5708
. : milestone, 5653,
iast_GLOBAL (3.546 ms) : 3487, 3604
. : milestone, 3546,
profiling (2.015 ms) : 1998, 2032
. : milestone, 2015,
tracing (1.802 ms) : 1787, 1817
. : milestone, 1802,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~1287c94bb7, baseline=1.59.0-SNAPSHOT~645ed325fc
dateFormat X
axisFormat %s
section baseline
no_agent (1.473 ms) : 1461, 1484
. : milestone, 1473,
appsec (3.74 ms) : 3516, 3963
. : milestone, 3740,
iast (2.224 ms) : 2158, 2289
. : milestone, 2224,
iast_GLOBAL (2.265 ms) : 2199, 2331
. : milestone, 2265,
profiling (2.089 ms) : 2034, 2143
. : milestone, 2089,
tracing (2.042 ms) : 1991, 2093
. : milestone, 2042,
section candidate
no_agent (1.475 ms) : 1464, 1487
. : milestone, 1475,
appsec (3.735 ms) : 3513, 3956
. : milestone, 3735,
iast (2.23 ms) : 2164, 2296
. : milestone, 2230,
iast_GLOBAL (2.261 ms) : 2194, 2327
. : milestone, 2261,
profiling (2.087 ms) : 2032, 2142
. : milestone, 2087,
tracing (2.06 ms) : 2008, 2112
. : milestone, 2060,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~1287c94bb7, baseline=1.59.0-SNAPSHOT~645ed325fc
dateFormat X
axisFormat %s
section baseline
no_agent (14.785 s) : 14785000, 14785000
. : milestone, 14785000,
appsec (14.942 s) : 14942000, 14942000
. : milestone, 14942000,
iast (18.045 s) : 18045000, 18045000
. : milestone, 18045000,
iast_GLOBAL (17.704 s) : 17704000, 17704000
. : milestone, 17704000,
profiling (14.741 s) : 14741000, 14741000
. : milestone, 14741000,
tracing (14.653 s) : 14653000, 14653000
. : milestone, 14653000,
section candidate
no_agent (15.479 s) : 15479000, 15479000
. : milestone, 15479000,
appsec (14.619 s) : 14619000, 14619000
. : milestone, 14619000,
iast (18.776 s) : 18776000, 18776000
. : milestone, 18776000,
iast_GLOBAL (18.033 s) : 18033000, 18033000
. : milestone, 18033000,
profiling (15.421 s) : 15421000, 15421000
. : milestone, 15421000,
tracing (14.822 s) : 14822000, 14822000
. : milestone, 14822000,
|
|
|
||
| this.optimizedMapEnabled = | ||
| configProvider.getBoolean(GeneralConfig.OPTIMIZED_MAP_ENABLED, false); | ||
| this.optimizedMapEnabled = configProvider.getBoolean(GeneralConfig.OPTIMIZED_MAP_ENABLED, true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious, if it is a config change, do we need to update some other place too?
@mhlidd Could you check this PR too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that only applies if we introduce a config variable. This config has been in place for some time now.
What Does This Do
Enables the "optimized" TagMap by default
Motivation
OptimizedTagMap is special HashMap that is designed to be good at common tracer usage patterns.
OptimizedTagMap uses immutable TagMap.Entry-s
By using immutable TagMap.Entry-s...
TagMap.Entry-s are also capable of storing primitives without boxing
All of these capabilities are intended to minimize the allocation done by the tracer when constructing Span-s
Additional Notes
Follow-up to
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]