Merged
Conversation
0xnm
approved these changes
Jun 24, 2022
| addError: emptyAsyncFunction, | ||
| addTiming: emptyAsyncFunction | ||
| }; | ||
| DdLogs.debug = emptyAsyncFunction; |
Member
There was a problem hiding this comment.
how do we maintain it if we add new function to the public API of the SDK? Should we have a checklist before the release to update this part of the doc?
Contributor
Author
There was a problem hiding this comment.
As discussed, we should push for users to use Expo Development builds. I've added a notice to the file that it might not be up to date.
xgouchet
approved these changes
Jun 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #223
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)