Skip to content

Sync Docker compose scripts with backend (DSpace/DSpace)#969

Merged
tdonohue merged 1 commit intoDSpace:mainfrom
tdonohue:sync_docker_with_backend
Dec 9, 2020
Merged

Sync Docker compose scripts with backend (DSpace/DSpace)#969
tdonohue merged 1 commit intoDSpace:mainfrom
tdonohue:sync_docker_with_backend

Conversation

@tdonohue
Copy link
Member

@tdonohue tdonohue commented Dec 9, 2020

The Docker compose scripts in the Angular UI have become outdated, and were never updated when the Entities test data set was updated on the backend in DSpace/DSpace#2623

This means that the data set being used for e2e tests in GitHub CI is outdated, and this has recently resulted in errors which are not reproducible on the more recent Entities test data set. For example in https://github.com/DSpace/dspace-angular/pull/961/checks?check_run_id=1524916589

This PR updates all Docker compose scripts to include:

  • Comments describing / linking back to related dockers scripts (in backend project)
  • Updates Entities data sets to the same ones used by Backend.
  • Other minor updates to sync the scripts with related backend scripts (as necessary)

@tdonohue
Copy link
Member Author

tdonohue commented Dec 9, 2020

🎉 Alongside DSpace/DSpace#3085 (which is already merged), this fixes the Docker backend for e2e tests! Merging this immediately. Anyone having issues with e2e tests failing cause of Docker problems should rebase their PR on main and hopefully that'll fix it.

@tdonohue tdonohue merged commit 39582c9 into DSpace:main Dec 9, 2020
@tdonohue tdonohue deleted the sync_docker_with_backend branch December 9, 2020 23:20
4science-it pushed a commit to 4Science/dspace-angular that referenced this pull request Nov 13, 2023
[CST-11855] Display Format and the Checksum for advanced attachment the information

Approved-by: Stefano Maffei
kosarko pushed a commit to ufal/dspace-angular that referenced this pull request Oct 23, 2025
* added missing prefix

* security: harden namespace handling in legacy bitstream redirect guard

* harden legacy bitstream redirect namespace

* removed security control

* modified curl, download bitstreams based on the name as separeated api calling

* remove -k argument from curl

* removed debug console
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant