Use codecov bash script instead of codecov node module#939
Merged
tdonohue merged 2 commits intoDSpace:mainfrom Nov 10, 2020
Merged
Use codecov bash script instead of codecov node module#939tdonohue merged 2 commits intoDSpace:mainfrom
tdonohue merged 2 commits intoDSpace:mainfrom
Conversation
Member
Author
|
Merging immediately, as this all succeeded & CodeCov results are now seemingly coming back to GitHub....the logs from CodeCov (see Travis logs) are also now more similar to those in DSpace/DSpace. |
kosarko
pushed a commit
to ufal/dspace-angular
that referenced
this pull request
Oct 23, 2025
* FIX: Add quotes to curl download command
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #935 to attempt to solve our ongoing Codecov issues.
Description
This PR simply switches us over to use the CodeCov Bash Script instead of using the
codecovnode module. This Bash Script is also used by DSpace/DSpace.Recently, we've had issues only in dspace-angular with CodeCov syncing to GitHub. Therefore, syncing this up with DSpace/DSpace (which is working fine).
Assuming Travis CI approves & Codecov analysis succeeds, then I plan to merge this immediately.