Comcol resource policies

[atarix83]

References

#848

Description

This PR adds implementation for collections/communities resource policy management.
Implementation is similar to the existing Item-level feature.

Instructions for Reviewers

• login as admin to the application
• open a community edit item page
• go to new authorizations tab and try to add/edit a new resource policy
• do the same for a collection

List of changes in this PR:

• added a new authorizations tab in the community edit page
  

• added a new authorizations tab in the community edit page
  

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

• My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
• My PR passes TSLint validation using yarn run lint
• My PR doesn't introduce circular dependencies
• My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
• My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
• If my PR includes new, third-party dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.

[lgtm-com]

This pull request fixes 1 alert when merging 0072486 into 9fc7320 - view on LGTM.com

fixed alerts:

• 1 for Unused variable, import, function or class

[artlowel]

Thanks @atarix83!

There's a small merge conflict at the moment, but apart from that: it works, and the code looks good

[tdonohue]

@atarix83 : Just a reminder, this PR has a merge conflict... it also should be rebased so that the GitHub CI tests run against this branch. Thanks!

[lgtm-com]

This pull request fixes 1 alert when merging c841a13 into aa8feb0 - view on LGTM.com

fixed alerts:

• 1 for Unused variable, import, function or class

[lgtm-com]

This pull request fixes 1 alert when merging 30d4c6a into 32a29c4 - view on LGTM.com

fixed alerts:

• 1 for Unused variable, import, function or class

[lgtm-com]

This pull request fixes 1 alert when merging 0f77e5c into 32a29c4 - view on LGTM.com

fixed alerts:

• 1 for Unused variable, import, function or class

[lgtm-com]

This pull request fixes 1 alert when merging c2e0ba9 into 63e0c2f - view on LGTM.com

fixed alerts:

• 1 for Unused variable, import, function or class

[atarix83]

@tdonohue this should be ok now

[tdonohue]

👍 Looks good to me now, @atarix83 ! I also tested it and everything is working as expected.

Therefore, I'm going to merge this as it's at +2.

NOTE for @artlowel : As I know you'll likely need to update #739 anyway after this merger, keep in mind there's a TODO in this PR in resource-policy-create.component.ts -- it might be unnecessary code once #739 is applied.

[artlowel]

NOTE for @artlowel : As I know you'll likely need to update #739 anyway after this merger, keep in mind there's a TODO in this PR in resource-policy-create.component.ts -- it might be unnecessary code once #739 is applied.

You're right, it was no longer necessary. Updated in #961