Merged
Conversation
|
This pull request introduces 1 alert when merging 653ceca into a937579 - view on LGTM.com new alerts:
|
tdonohue
reviewed
Nov 6, 2020
tdonohue
approved these changes
Nov 18, 2020
Member
tdonohue
left a comment
There was a problem hiding this comment.
👍 Looks great. Tested and it works as described, both for an existing & non-existing handle. Thanks @YanaDePauw !
kosarko
pushed a commit
to ufal/dspace-angular
that referenced
this pull request
Oct 23, 2025
Co-authored-by: Matus Kasak <matus.kasak@dataquest.sk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference
This PR refers to issue #833.
Description
This PR fixes the issue where navigation to a handle page (Example: http://localhost:4000/handle/10673/1490) fails.
Instructions for Reviewers
To test that the handle redirect works, perform the following steps:
Checklist
yarn run lintpackage.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.