Skip to content

remove remaining uses of /api in the rest namespace#877

Merged
tdonohue merged 2 commits intoDSpace:mainfrom
atmire:remove-api-from-rest-config
Sep 30, 2020
Merged

remove remaining uses of /api in the rest namespace#877
tdonohue merged 2 commits intoDSpace:mainfrom
atmire:remove-api-from-rest-config

Conversation

@artlowel
Copy link
Member

@artlowel artlowel commented Sep 30, 2020

References

Description

This PR removes /api from the rest namespaces of environment.common.ts and .travis.yml, as it was deprecated in #825

Instructions for Reviewers

  • Test this PR by verifying the travis build works, and that the build logs don't show the deprecation warning.
  • Test that if you don't override the rest namespace in your local environment files, you don't get the deprecation warning when building.

If you notice any other uses of /api I've forgotten please let me know.

Checklist

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes TSLint validation using yarn run lint
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new, third-party dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.

@artlowel artlowel self-assigned this Sep 30, 2020
@artlowel artlowel added the 1 APPROVAL pull request only requires a single approval to merge label Sep 30, 2020
@artlowel artlowel added this to the 7.0beta4 milestone Sep 30, 2020
@tdonohue
Copy link
Member

@artlowel : This looks good at a glance... though I see three more places where /api needs cleanup:

So, if we could add those, then I think this would be ready to go.

Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks correct to me. I also gave this some light testing and noticed no issues (and the warning has disappeared as expected).

@tdonohue tdonohue merged commit 03bba0f into DSpace:main Sep 30, 2020
tdonohue added a commit to DSpace/DSpace that referenced this pull request Sep 30, 2020
Copy link
Member

@mwoodiupui mwoodiupui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 by inspection. Looks right.

kosarko added a commit to ufal/dspace-angular that referenced this pull request Jun 25, 2025
* use `$DSPACE_REST_NAMESPACE` for the webapps symlink

(cherry picked from commit 9ea936e)

* Licenses sync

(cherry picked from commit 4ee2f1c)

* update header/footer

based on latest lindat-common 3.5.0

(cherry picked from commit 7b2f299)

* expose both tcp & udp ports of the handle server

(cherry picked from commit 46bc936)

* Update docker-compose-rest.yml

replace ../webapps with /usr/local/tomcat/webapps

---------

Co-authored-by: Ondrej Kosarko <okosarko@lindat-repository-ng.services.ufal.cloud>
Co-authored-by: Ondrej Kosarko <okosarko@lindat.mff.cuni.cz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants