remove remaining uses of /api in the rest namespace#877
Merged
tdonohue merged 2 commits intoDSpace:mainfrom Sep 30, 2020
Merged
remove remaining uses of /api in the rest namespace#877tdonohue merged 2 commits intoDSpace:mainfrom
tdonohue merged 2 commits intoDSpace:mainfrom
Conversation
Member
|
@artlowel : This looks good at a glance... though I see three more places where
So, if we could add those, then I think this would be ready to go. |
tdonohue
approved these changes
Sep 30, 2020
Member
tdonohue
left a comment
There was a problem hiding this comment.
👍 Looks correct to me. I also gave this some light testing and noticed no issues (and the warning has disappeared as expected).
tdonohue
added a commit
to DSpace/DSpace
that referenced
this pull request
Sep 30, 2020
mwoodiupui
reviewed
Sep 30, 2020
Member
mwoodiupui
left a comment
There was a problem hiding this comment.
+1 by inspection. Looks right.
6 tasks
kosarko
added a commit
to ufal/dspace-angular
that referenced
this pull request
Jun 25, 2025
* use `$DSPACE_REST_NAMESPACE` for the webapps symlink (cherry picked from commit 9ea936e) * Licenses sync (cherry picked from commit 4ee2f1c) * update header/footer based on latest lindat-common 3.5.0 (cherry picked from commit 7b2f299) * expose both tcp & udp ports of the handle server (cherry picked from commit 46bc936) * Update docker-compose-rest.yml replace ../webapps with /usr/local/tomcat/webapps --------- Co-authored-by: Ondrej Kosarko <okosarko@lindat-repository-ng.services.ufal.cloud> Co-authored-by: Ondrej Kosarko <okosarko@lindat.mff.cuni.cz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
/apiwere deprecated by Add robots.txt #825Description
This PR removes
/apifrom the rest namespaces ofenvironment.common.tsand.travis.yml, as it was deprecated in #825Instructions for Reviewers
If you notice any other uses of
/apiI've forgotten please let me know.Checklist
yarn run lintpackage.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.