Removal of email option for the curation script#855
Merged
tdonohue merged 1 commit intoDSpace:mainfrom Sep 2, 2020
Merged
Conversation
…2926 (review) for full explanation
5 tasks
artlowel
added
the
1 APPROVAL
tdonohue
approved these changes
Sep 2, 2020
Member
tdonohue
left a comment
tdonohue
left a comment
There was a problem hiding this comment.
👍 Code changes look good. Tested with DSpace/DSpace#2926 and it works as expected now! Thanks @jonas-atmire
dsipos-dev
added a commit
to qultoltd/dspace-angular
that referenced
this pull request
Oct 9, 2020
4science-it
pushed a commit
to 4Science/dspace-angular
that referenced
this pull request
Oct 11, 2023
[DSC-1251] consider empty value of configuration key request.item.type Approved-by: Vincenzo Mecca
kosarko
added a commit
to ufal/dspace-angular
that referenced
this pull request
May 20, 2025
* Create Acknowledgment-ReadMe.md Acnkowledgment of NRP project (cherry picked from commit ad889b2) * Video files previews This uses the thumbnail as poster (if available) and correctly sets the source of the video currently only works for anonymously accessible files. (cherry picked from commit 4832c2f) * Handle video previews for restricted items append a shortlived token at the right time (error, seeking, stalled) (cherry picked from commit 2c12d7d) * Display only ORIGINAL bitstreams Thumbnails, when available, should be shown istead of the generic MIME_TYPE_IMAGE. Content of the TEXT bundle should not be shown at all this is usually automatically extracted "text layer" of a PDF, useful for indexing, but don't want people downloading it. (cherry picked from commit 3862442) * fix linter and test errors (cherry picked from commit f852096) * Code review follow up the listOfFiles should really not contain files from "TEXT" or "THUMBNAIL" bundles. * code review unsubscribe error$, seeking$ and $stalled * code review - thumbnail might be undefined * code review - consistent formatting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Description
This PR will remove the "email/-e" option from the curate script on Angular's end. See linked PR for REST related info.
Instructions for Reviewers
In the CurationFormComponent:
In the related test component
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
yarn run lintpackage.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.