Upgrade angular 7

[atarix83]

This PR provides upgrade to angular 7.

Tests run successful and all seem to work fine.

I removed the webpack's resolve-url-loader from dependencies because it doesn't work but everything else seems to work the same.

[tdonohue]

@atarix83 : Thanks for this! I gave this a quick code review today, and it mostly looks fine to me. There's one new method which is added that needs TypeDocs & tests (and this method is pointed out by Coveralls in the coverage drop, so it may be a small part of the issue here).

That said, currently this PR fails to run with AoT compilation (yarn start). It looks like it may just be a minor issue, but here's the error I see:

    ERROR in build/app/shared/form/builder/ds-dynamic-form-ui/relation-lookup-modal/search-tab/dynamic-lookup-relation-search-tab.component.spec.ts(116,7): error TS2554: Expected 0-1 arguments, but got 2.
    build/app/shared/form/builder/ds-dynamic-form-ui/relation-lookup-modal/search-tab/dynamic-lookup-relation-search-tab.component.spec.ts(140,7): error TS2554: Expected 0-1 arguments, but got 2.
    build/app/shared/object-list/selectable-list/selectable-list.service.spec.ts(53,41): error TS2345: Argument of type 'Store<SelectableListsState>'
is not assignable to parameter of type 'Store<AppState>'.
      Type 'SelectableListsState' is not assignable to type 'AppState'.
        Property 'router' is missing in type 'SelectableListsState'.

It does run if you use yarn run watch (and testing it out it seems to work fine). The above error only occurs when using yarn start.

[tdonohue]

@atarix83 : I retested this today, and based on your latest changes the AoT compilation now succeeds! So, thanks for those updates!

I think this is looking good, but I would like to see if we can add tests to the new function I mentioned above -- this new function is specifically called out by the Coveralls report as having a big impact on code coverage. I suspect if you added some tests for it, we might get the coverage to increase slightly (maybe get us closer to 78% or 79% again). Beyond that, I'd personally like to see this effort merged soon, as the next step will be to also upgrade us to Angular 8.

[artlowel]

Thanks @atarix83

It works, and the changes look good apart from a few minor questions I had about the changes to the store state types, and @tdonohue's comments.

Could you also try to merge #553 to see if it doesn't cause any issues with this PR?

[atarix83]

@artlowel I should resolve your reported issue
@tdonohue I've added tests for menuKeySelector and SidebarFilterService but coverage is stiil decreased

[tdonohue]

👍 Thanks for the updates, @atarix83 . I gave this some more testing today, and I'm not noticing any obvious issues with the UI after the upgrade. I also don't see any obvious reasons why the code coverage has dropped so significantly. So, in order to move this forward (and unblock the Angular 8 upgrade), I'm OK with merging this as-is. Thanks again!

[artlowel]

Thanks @atarix83!