Skip to content

Small bug-fix due to changes to relationship-type#494

Merged
tdonohue merged 3 commits intoDSpace:masterfrom
atmire:Changes-to-relationship-type-fix
Oct 3, 2019
Merged

Small bug-fix due to changes to relationship-type#494
tdonohue merged 3 commits intoDSpace:masterfrom
atmire:Changes-to-relationship-type-fix

Conversation

@Atmire-Kristof
Copy link
Contributor

After the recent merge of #461 into master, my local builds were failing.
This is the error I received:

ERROR in src/app/core/data/relationship.service.ts(185,25): error TS2339: Property 'leftLabel' does not exist on type 'RelationshipType'.
    src/app/core/data/relationship.service.ts(187,25): error TS2339: Property 'rightLabel' does not exist on type 'RelationshipType'.

I renamed these leftover properties to their appropriate name (as they seem to have been forgotten in the PR mentioned above).

Copy link
Member

@benbosman benbosman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this locally and it worked correctly for me.
The changes seem correct to me as well
This seems to have been forgotten in #461 although building #461 did work initially

Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 This looks obvious to me. These various properties have been renamed, so using the old names definitely will not work. Merging this immediately as it seems like an obvious quick fix.

@tdonohue tdonohue merged commit 262b332 into DSpace:master Oct 3, 2019
@tdonohue tdonohue added this to the 7.0beta1 milestone Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants