Configuration search page component#442
Conversation
|
Should be considered the new endpoint intead: https://dspace7-entities.atmire.com/server |
|
For helping others who would like to test this. You will see visible results of this PR if you try to access: |
paulo-graca
left a comment
paulo-graca
left a comment
There was a problem hiding this comment.
This PR performs as expected.
But during my tests I found this issue: https://jira.duraspace.org/browse/DS-4324
It seems to me a problem regarding default configuration, I didn't dig enough.
Thank you @Atmire-Kristof !
tdonohue
left a comment
tdonohue
left a comment
There was a problem hiding this comment.
👍 Works great!
That said, because of this new, better implementation, @benbosman I'd recommend we rename these configurations: https://github.com/DSpace/DSpace/blob/master/dspace/config/spring/api/discovery.xml#L57-L62
As the UI is now allowing paths based on those configurations, we shouldn't have paths of /search/personConfiguration and instead simplify this to /search/person, etc. I'll create a JIRA ticket for this change.
|
Followup JIRA ticket created: https://jira.duraspace.org/browse/DS-4325 As this is at +2, I'm merging this immediately. Thanks @Atmire-Kristof ! |
4 participants
This PR replaces the search pages based on fixed filters with a search based on configuration instead. This allows us to e.g. link to a search for a specific type of entity that has a different set of facets from the default search page. You can find these pages under
/search/${configurationName}.If you test this PR against the entities demo rest api (https://dspace7-entities.atmire.com/rest) you can try
/search/personConfiguration. (Note that the name of those configurations can be chosen in the config, so on a production system a better name would beperson, as that results in a better UI URI)The original FilteredSearchPageComponent still exists, as it is used on other pages as well, but it no longer has a direct route to it.