Enable type-bind for checkbox inputs during submission#2693
Merged
tdonohue merged 1 commit intoDSpace:mainfrom Apr 30, 2024
Merged
Enable type-bind for checkbox inputs during submission#2693tdonohue merged 1 commit intoDSpace:mainfrom
tdonohue merged 1 commit intoDSpace:mainfrom
Conversation
|
We have the same problem, if a field is a list but unrepeatable, it will display with a radio in the submission. This radio but didn't work with type-bind together. With this changes it works as well! I've tested on my local system with release 7.6.1 and would like to verify this solution. |
tdonohue
approved these changes
Apr 30, 2024
Member
tdonohue
left a comment
There was a problem hiding this comment.
👍 Thanks @hutattedonmyarm ! I finally got to testing this today and your fix works!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
dspace-7_xin [Port dspace-7_x] Enable type-bind for checkbox inputs during submission #2694Description
Short summary of changes (1-2 sentences).
Instructions for Reviewers
List of changes in this PR:
DynamicListRadioGroupModelandDynamicListModelConfigrepeatableis set tofalsefor the list itemChecklist
yarn lintyarn check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.