ECOMMONS-1548 - fix for hamburger menu not working in mobile firefox/safari#2471
Closed
bmckinney wants to merge 87 commits intoDSpace:mainfrom
Closed
ECOMMONS-1548 - fix for hamburger menu not working in mobile firefox/safari#2471bmckinney wants to merge 87 commits intoDSpace:mainfrom
bmckinney wants to merge 87 commits intoDSpace:mainfrom
Conversation
Author
|
sorry, pushed this to the wrong origin! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Description
Enables use of hamburger menu for mobile firefox/safari
Instructions for Reviewers
Resize firefox and safari to mobile and test opening and selecting items in the hamburger menu.
List of changes in this PR:
To test iPhone via playwright: