2437 Correct and clarify commented-out code in several custom components#2438
Merged
tdonohue merged 2 commits intoDSpace:mainfrom Aug 23, 2023
Merged
Conversation
- Correct the path in commented-out code in the custom theme's components - Clarify that the workflow-item-sen-back.component.scss file is a stub - It has no corresponding SCSS file in the base theme
tdonohue
added
bug
code task
themes
1 APPROVAL
tdonohue
approved these changes
Aug 23, 2023
Member
tdonohue
left a comment
tdonohue
left a comment
There was a problem hiding this comment.
👍 Thanks @hardyoyo ! This is very obviously correct & only updates comments (no actual code changes). But you are correct, these paths should all start with ./ in the "custom" theme to ensure the file in the current directory is used.
Contributor
|
Successfully created backport PR for |
tdonohue
removed
the
port to dspace-7_x
4science-it
pushed a commit
to 4Science/dspace-angular
that referenced
this pull request
Oct 25, 2024
…request DSpace#2438) [DSC-1864] fix template function Approved-by: Giuseppe Digilio
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Description
components
Instructions for Reviewers
n/a
List of changes in this PR:
(see description)
Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.
Issue #2437 contains a description of how to reproduce. With this patch applied, confirm the bug is no longer present, and that the footer is easily customizable.
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
yarn lintyarn check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.