Search query is not set by default when opening an external sources tab#2376
Merged
tdonohue merged 3 commits intoDSpace:mainfrom Sep 7, 2023
Conversation
… the form value already filled in the search input
…tabs_contribute-7.6
…rnalSourceTabComponent
8133193 to
5062e46
Compare
tdonohue
approved these changes
Sep 7, 2023
Member
tdonohue
left a comment
There was a problem hiding this comment.
👍 Thanks @alexandrevryghem ! Verified this works as described. Searched value is passed to the popup modal, and if I switch to an external source tab (like ORCID) it's passed there as well.
Member
|
Merged to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Description
In a previous PR I made it possible to pass the already filled input value of a relation field to the search bar from the popup modal. That fix only worked for the internal entities tab, this PR now also fixes this for the tab for external sources tabs.
Instructions for Reviewers
List of changes in this PR:
@Input query: stringto theDsDynamicLookupRelationExternalSourceTabComponentquerythat was already filled in the form to the component inDsDynamicLookupRelationModalComponentGuidance for how to test/review this PR:
Checklist
yarn lintyarn check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.