Fix setStaleByHrefSubstring not emitting true when all requests are stale#2349
Merged
tdonohue merged 3 commits intoDSpace:mainfrom Sep 7, 2023
Conversation
tdonohue
added
bug
1 APPROVAL
…g-not-emitting-after-all-requests-were-stale_contribute-7.4' into fix-setStaleByHrefSubtring-not-emitting-after-all-requests-were-stale_contribute-7.6 # Conflicts: # src/app/core/data/request.service.ts
alexandrevryghem
removed
the
port to dspace-7_x
alexandrevryghem
force-pushed
the
fix-setStaleByHrefSubtring-not-emitting-after-all-requests-were-stale_contribute-main
branch
from
c35b8ab to
273be5b
Compare
tdonohue
approved these changes
Sep 7, 2023
Member
tdonohue
left a comment
tdonohue
left a comment
There was a problem hiding this comment.
👍 Thanks @alexandrevryghem ! The code here looks reasonable & has tests. I also manually tested a few of the pages/components that use setStaleByHrefSubscring to verify no changes in behavior (and there are none that I see).
Member
|
Applied to |
alexandrevryghem
deleted the
fix-setStaleByHrefSubtring-not-emitting-after-all-requests-were-stale_contribute-main
branch
4science-it
pushed a commit
to 4Science/dspace-angular
that referenced
this pull request
Oct 10, 2024
[DSC-1775] port fixes for open graph metadata Approved-by: Andrea Barbasso
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
setStaleByHrefSubstringnot emitting true when all requests are stale #2404Description
In #961
removeByHrefSubstring()was renamed tosetStaleByHrefSubstring(), but its return statement was never updated. It will still only emit if the requests are removed from the store entirely, which will no longer happen now. This means it will never emit.This PR updates it so it emits after all requests are set to stale instead.
Checklist
yarn lintyarn check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.