Skip to content

Add validate only check in the Import Metadata page#1636

Merged
tdonohue merged 7 commits intoDSpace:mainfrom
4Science:feature/CST-5329
May 12, 2022
Merged

Add validate only check in the Import Metadata page#1636
tdonohue merged 7 commits intoDSpace:mainfrom
4Science:feature/CST-5329

Conversation

@atarix83
Copy link
Copy Markdown
Contributor

@atarix83 atarix83 commented May 2, 2022

References

Add references/links to any related issues or PRs. These may include:

Description

This PR add the --validate-only flag to the metadata import page
Schermata da 2022-05-02 16-06-34

Instructions for Reviewers

As admin open the metadata-import page (admin/metadata-import) and check the new checkbox works properly

Checklist

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes TSLint validation using yarn run lint
  • My PR doesn't introduce circular dependencies
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new, third-party dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.

@tdonohue tdonohue added 1 APPROVAL pull request only requires a single approval to merge new feature tools: import labels May 2, 2022
@tdonohue tdonohue added this to the 7.3 milestone May 2, 2022
@tdonohue tdonohue self-requested a review May 5, 2022 14:14
Copy link
Copy Markdown
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@atarix83 : Thanks! I tested this and it works exactly as described. I just have one small comment.

I think we should add a "hint" (formatted like hints in the submission form) under the "Validate Only" checkbox to describe its behavior.

@tdonohue tdonohue self-requested a review May 12, 2022 17:32
Copy link
Copy Markdown
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @atarix83 ! This looks good to me now. Re-tested today and everything is working well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge high priority new feature tools: import

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Import Metadata CSV (Enhanced, with Preview of Changes, as in v6.x)

2 participants