Merged
Conversation
tdonohue
approved these changes
Apr 27, 2021
Member
tdonohue
left a comment
There was a problem hiding this comment.
👍 Looks good to me, thanks @Atmire-Kristof ! I also built it and gave it some light testing and I'm not noticing any adverse effects.
kosarko
pushed a commit
to ufal/dspace-angular
that referenced
this pull request
Jan 7, 2026
* Added a volume for postgres logs * Change array command into single line
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Description
This PR fixes a number of tests that were broken or disabled due to the Angular 10 upgrade.
Instructions for Reviewers
Changes made:
xdescribeusing this approachrelationship.effects.spec.tsrelated to debounceTime, added an InjectionToken for the operator and injected it into the effects. Modified the test cases to create a spy on this injected operator.How to test:
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
yarn run lintpackage.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.