Fix or address string escaping / replacement issues reported by LGTM#1060
Merged
tdonohue merged 3 commits intoDSpace:mainfrom Mar 31, 2021
Merged
Conversation
|
This pull request fixes 2 alerts when merging 0f782ef into 1115c58 - view on LGTM.com fixed alerts:
|
tdonohue
added
the
1 APPROVAL
LotteHofstede
force-pushed
the
w2p-77215_lgtm-issues-and-sanitization
branch
from
0f782ef to
0488cd6
Compare
|
This pull request fixes 2 alerts when merging 0488cd6 into 66463cf - view on LGTM.com fixed alerts:
|
tdonohue
requested changes
Mar 22, 2021
Member
tdonohue
left a comment
tdonohue
left a comment
There was a problem hiding this comment.
@Raf-atmire : While this looks mostly correct, I'm still a little worried about the RegExp we are creating... See my below request for an additional test to verify it.
|
This pull request introduces 1 alert and fixes 2 when merging 7afcebf into ea3886b - view on LGTM.com new alerts:
fixed alerts:
|
|
This pull request fixes 2 alerts when merging 947d792 into ea3886b - view on LGTM.com fixed alerts:
|
tdonohue
approved these changes
Mar 31, 2021
Member
tdonohue
left a comment
tdonohue
left a comment
There was a problem hiding this comment.
👍 Thanks @Raf-atmire , this looks good now.
4science-it
pushed a commit
to 4Science/dspace-angular
that referenced
this pull request
Nov 27, 2023
…evel (pull request DSpace#1060) DSC-1379 security for nested metadata shoul take security level Approved-by: Giuseppe Digilio
kosarko
pushed a commit
to ufal/dspace-angular
that referenced
this pull request
Nov 11, 2025
…ui.json not the /app/docker/dspace-ui.json (DSpace#1060)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Description
This PR ensures that the LGTM issues are either resolved or ignored.
Instructions for Reviewers
List of changes in this PR:
This PR can be tested by inspecting LGTM and ensuring that no security issues are shown
Checklist
yarn run lintpackage.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.