Support a short lived token using GET to deal with CSRF in Angular#159
Merged
tdonohue merged 1 commit intoDSpace:mainfrom Apr 1, 2021
Merged
Support a short lived token using GET to deal with CSRF in Angular#159tdonohue merged 1 commit intoDSpace:mainfrom
tdonohue merged 1 commit intoDSpace:mainfrom
Conversation
tdonohue
approved these changes
Apr 1, 2021
Member
tdonohue
left a comment
tdonohue
left a comment
There was a problem hiding this comment.
👍 Looks good to me. Thanks for this @benbosman !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is related to DSpace/dspace-angular#1004 (comment)
It adds the GET endpoint as an alternative, which is only available from the trusted IP