Conversation
and made the file sanitizer a copy-less function
luca-schlecker
approved these changes
Jan 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR fixes 2 Vulnerabilities found in Crow.
staticdirectory and Mustache'stemplatesdirectory.Once merged, This PR, along with #292, #296, and #304 Will be released immediately as part of
v0.3+4.Note: This PR introduces a slowdown between
50µsand1.5msfor any static file or template being loaded (depending on the length of the filename). Therefore I would advise optimization of thesanitize_filename()function before the next minor/major release.A special Thank you to the Snyk Security team for their effort in identifying and reporting these vulnerabilities.