An iOS hack should only exist on iOS#262
Merged
lannymcnie merged 2 commits intoCreateJS:masterfrom Jan 31, 2017
Merged
Conversation
NuclearCookie
force-pushed
the
fix/edge_error
branch
from
0a0bc5f to
6ce1ebe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Edge I received the following error message:
Unlike the spec, saying that this code should throw, Edge logs an error and does not throw.
So I figured the best approach to fix this is to only execute the hack on iOS ( it's only needed there according to the comment ).