This repository was archived by the owner on Feb 24, 2025. It is now read-only.
Merged
Conversation
pvaiko
force-pushed
the
3012-bug_sp-bale-collecting-and-wrapping
branch
from
0fe765e to
c68f1e0
Compare
Retry with another bale if the pathfinding fails with invalid goal, meaning there is likely another bale near the target.
- did not store the last checked bale properly - obstacle check was not working because missing return #3012
pvaiko
force-pushed
the
3012-bug_sp-bale-collecting-and-wrapping
branch
from
c68f1e0 to
fd841e2
Compare
Don't use the pathfinder controller retry logic as we don't want to retry with the same goal. Give up after 3 retries. Try another bale if the goal node is invalid, or failed, but not close to the field edge. If close to the field edge, back up a bit and start again. Keep a list of bales tried to avoid retrying the same two bales and causing a stack overflow.
when everything fails, reverse and try again
Stop retrying also when there are no retryable bales left.
Separate states for reversing due to obstacle or pathfinder failure.
Rescan field if bumped into another bale while driving to the target, to make sure it isn't on the list anymore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retry with another bale if the pathfinding fails with invalid goal, meaning there is likely another bale near the target.