Skip to content

Add acts_as_lesson_plan_item decorator#176

Closed
kxmbrian wants to merge 10 commits intoCoursemology:masterfrom
coursemology-collab:acts_as_lesson_plan_item
Closed

Add acts_as_lesson_plan_item decorator#176
kxmbrian wants to merge 10 commits intoCoursemology:masterfrom
coursemology-collab:acts_as_lesson_plan_item

Conversation

@kxmbrian
Copy link
Contributor

Please merge #167 first.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Method has too many lines. [11/10]

@kxmbrian kxmbrian changed the title Acts as lesson plan item Add acts_as_lesson_plan_item decorator Apr 16, 2015
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after_initialize :set_default_values if: :new_record? so this function only been called upon creation.

@kxmbrian kxmbrian force-pushed the acts_as_lesson_plan_item branch from 7629796 to 10443af Compare April 16, 2015 12:54
@kxmbrian kxmbrian force-pushed the acts_as_lesson_plan_item branch from 10443af to 1d4dbda Compare April 16, 2015 13:19
@kxmbrian
Copy link
Contributor Author

kxmbrian commented May 7, 2015

Replaced by #185, which is merged from a name-spaced branch instead. Also, a cherry-picked commit was added.

@kxmbrian kxmbrian closed this May 7, 2015
@kxmbrian kxmbrian deleted the acts_as_lesson_plan_item branch May 7, 2015 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments