Add dedicated benchmarking test suite #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regexident
changed the title
Codecov Report
@@ Coverage Diff @@
## master #34 +/- ##
==========================================
+ Coverage 73.4% 74.51% +1.11%
==========================================
Files 30 30
Lines 1440 1440
==========================================
+ Hits 1057 1073 +16
+ Misses 383 367 -16
Continue to review full report at Codecov.
|
MaxDesiatov
previously approved these changes
Dec 22, 2018
MaxDesiatov
previously approved these changes
Dec 22, 2018
MaxDesiatov
previously approved these changes
Dec 22, 2018
MaxDesiatov
requested changes
Dec 22, 2018
Collaborator
MaxDesiatov
left a comment
MaxDesiatov
left a comment
There was a problem hiding this comment.
thanks @regexident, but there are a few small changes needed: removing print and trailing whitespaces
MaxDesiatov
previously approved these changes
Dec 22, 2018
Collaborator
|
hm, now a benchmark test fails on CI... |
Contributor
Author
|
Yeah, I noticed that, too. 🤨 |
This was referenced Dec 22, 2018
Contributor
Author
|
These benchmarks currently cause XMLCoder to hard crash with a fatal error. |
MaxDesiatov
pushed a commit
that referenced
this pull request
Dec 23, 2018
There were way too many functions returning `throw -> _?` in `XMLDecoder`, which should only ever return `throw -> _` (turning the `nil` case into an error of its own). 👷🏻♀️ I also managed to get rid of quite a bunch of force-unwraps. Especially the ones eventually leading to crashes in #38 and #34. 💥 * Make error handling in `XMLDecoder` simpler & safer * SwiftFormat and related cleanup
MaxDesiatov
approved these changes
Jan 10, 2019
hodovani
approved these changes
Jan 10, 2019
MaxDesiatov
pushed a commit
that referenced
this pull request
May 22, 2019
#34 encounters a crasher when trying to decode nested arrays. This PR tries to add some more tests for nested keyed/unkeyed collections: - `[String: [Int]]` (dictionary of arrays) - `[String: [String: Int]]` (dictionary of dictionaries) - `[[Int]]` (array of arrays) - `[[String: Int]]` (array of dictionaries) * Added tests for nested complex (keyed/unkeyed) boxes * Fix trailing whitespace and indentation * Remove whitespace between doc comment and code * Avoid conflict in XMLDecoder.swift
arjungupta0107
pushed a commit
to salido/XMLCoder
that referenced
this pull request
Jun 26, 2020
CoreOffice#34 encounters a crasher when trying to decode nested arrays. This PR tries to add some more tests for nested keyed/unkeyed collections: - `[String: [Int]]` (dictionary of arrays) - `[String: [String: Int]]` (dictionary of dictionaries) - `[[Int]]` (array of arrays) - `[[String: Int]]` (array of dictionaries) * Added tests for nested complex (keyed/unkeyed) boxes * Fix trailing whitespace and indentation * Remove whitespace between doc comment and code * Avoid conflict in XMLDecoder.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Admittedly the
_ closure: (() -> ()) -> ()+closure { … }mumbo jumbo isn't the prettiest code I've ever written, but then again XCTest isn't a particularly usable testing framework either. 🤷🏻♂️Xcode attaches the measurements popover to literal code occurrences of
self.measure { … }itself, making the whole mess required in the first place. 🙄(All while only supporting a single
self.measure { … }per unit test. 🤦🏻♂️)