Conversation
sfalexrog
left a comment
sfalexrog
left a comment
There was a problem hiding this comment.
Sounds like a good idea and looks nice, exactly what newcomers would want. Not sure about two modes and Javascript-side shell scripting.
On a somewhat related note, how about a web UI for dynamic_reconfigure?
| <param name="rainbow_period" value="5"/> | ||
| <!-- events effects table --> | ||
| <rosparam param="notify" if="$(arg led_notify)"> | ||
| <rosparam param="notify" if="$(eval led_notify == 'all')"> |
There was a problem hiding this comment.
Maybe we could have a set of default notifications and append to it somehow?
There was a problem hiding this comment.
Don't completely get what you mean.
| # # myfile2 | ||
| # DESTINATION ${CATKIN_PACKAGE_SHARE_DESTINATION} | ||
| # ) | ||
|
|
There was a problem hiding this comment.
You really want to add something like catkin_install_python here.
|
|
||
| ## Modes | ||
|
|
||
| `roslaunch_editor` works in two modes: standalone mode (where running `editor` node is required), and Clover mode (where `clover`'s `shell` node, `roswww_static` and `rosbridge_suite` are utilized). The editor will read and write launch-files and restart the nodes (if configured) using one of these nodes. |
There was a problem hiding this comment.
Honestly, I'd prefer a single (standalone) mode. We've discussed shell before, and even though I understand its usefulness, I'm not in favor of it being used.
| @@ -0,0 +1,140 @@ | |||
| <html> | |||
| <head> | |||
| <script src="roslib.js"></script> | |||
There was a problem hiding this comment.
roslib.js will probably be used in all web-based plugins, how about moving it to roswww_static?
There was a problem hiding this comment.
What do you mean, /roswww_static/roslib.js? What about different versions might be needed? Also, I'm thinking on not requiring roswww_static for this. Plus, for now, it's compatible with roswww, too.
| @@ -0,0 +1,287 @@ | |||
| var editorElem = document.querySelector('form.editor'); | |||
|
|
|||
| var items = {}; | ||
|
|
||
| function generateForm(item, content) { | ||
| var parser = new DOMParser(); |
There was a problem hiding this comment.
Isn't let/const the new hotness in JS?
|
|
||
| if (clover) { | ||
| const boundary = '===BOUNDARY==='; | ||
| var cmd = 'bash -ic "' + p.items.map(function(item) { |
There was a problem hiding this comment.
Calling bash from JS seems... odd, and the other branch looks much cleaner. Just sayin'.
|
Another thing of note: is it ROS-like to put executable Python scripts in |
2 participants
Add
roslaunch_editor– a GUI for configuring launch files. It can work in "clover" mode (throughshellnode) or in "standalone" mode (requiring a special backend node).Also adjusted arguments for more novice-friendly configuration.
TODO: