Skip to content

Fix/script path assets prefix and ctx warn bug #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dsarno merged 2 commits into from
Dec 11, 2025
Merged

Fix/script path assets prefix and ctx warn bug #453

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1628474
Fix script path handling and FastMCP Context API usage
dsarno Dec 11, 2025
1d9ed01
Fix manage_asset error handling to use ctx.error
dsarno Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion MCPForUnity/Editor/Tools/ManageScript.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,17 @@ private static bool TryResolveUnderAssets(string relDir, out string fullPathDir,
// Normalize caller path: allow both "Scripts/..." and "Assets/Scripts/..."
string rel = (relDir ?? "Scripts").Replace('\\', '/').Trim();
if (string.IsNullOrEmpty(rel)) rel = "Scripts";
if (rel.StartsWith("Assets/", StringComparison.OrdinalIgnoreCase)) rel = rel.Substring(7);

// Handle both "Assets" and "Assets/" prefixes
if (rel.Equals("Assets", StringComparison.OrdinalIgnoreCase))
{
rel = string.Empty;
}
else if (rel.StartsWith("Assets/", StringComparison.OrdinalIgnoreCase))
{
rel = rel.Substring(7);
}

rel = rel.TrimStart('/');

string targetDir = Path.Combine(assets, rel).Replace('\\', '/');
Expand Down
2 changes: 1 addition & 1 deletion Server/src/services/tools/manage_asset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ async def _normalize_properties(raw: dict[str, Any] | str | None) -> tuple[dict[

properties, parse_error = await _normalize_properties(properties)
if parse_error:
await ctx.warn(parse_error)
await ctx.error(parse_error)
return {"success": False, "message": parse_error}

# Coerce numeric inputs defensively
Expand Down