fixed bug where it would crash if you filled in all canidates + write in #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
It looks like if I rank 2 votes with the same vote (i.e. choice 1 has rank choice 1 and choice 2 has rank choice 1) it doesn't throw an error |
Merged
shaeespring
added a commit
that referenced
this pull request
Jan 20, 2026
* fixed bug where it would crash if you filled in all canidates + write in (#46) * Check that candidates are not ranked identically (#47) * Check that candidates are not ranked identically * fix bug where write in candidates weren't checked for duplicate rankings * simplified range cause yeah * i think i actually fixed it this time * http response for consistency * removed extra period --------- Co-authored-by: Noah <[email protected]> * Always stop once the majority is hit (#50) @tallen42 * Always stop at majority * End is always true if finalResult is calculated * If hidden, say results soon, otherwise URL (#51) @tallen42 * yippee sonarqube support (#54) @Will-Hellinger * Set up golang CI * go mod tidy * gofmt * Allow hiding results while poll is open this replaces the current hide functionality * Clarify dev setup for compose * go mod download as a separate layer for caching * Allow alumni to dev * Make polls modifiable by removing Reveal Polls that are hidden really shouldn't be revealed * Create dev mode evals override * Clarify gatekeep autoclose for evals * Initial setup for golang tests * Rewrite orderOptions to avoid hanging Also write tests * Run go vet * Maintainability (#58) * min number and cognitive complexity * variable name * revert match constant and import math * Logging dependabot readme pr template (#59) * remove debug log call and added dev flags log messages * update readme with some todos * Create pull request template * Add Dependabot configuration for Go modules * oops forgot target-branch --------- Co-authored-by: Noah Hanford <[email protected]> Co-authored-by: Tyler Allen <[email protected]> Co-authored-by: William Hellinger <[email protected]> Co-authored-by: Max Meinhold <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to test: make ranked choice vote with write in and then do all of the above (it doesn't crash now)