Skip to content

Add preview for web import screens#928

Merged
egorikftp merged 1 commit intomainfrom
task/add-preview-for-web-import-screens
Mar 7, 2026
Merged

Add preview for web import screens#928
egorikftp merged 1 commit intomainfrom
task/add-preview-for-web-import-screens

Conversation

@egorikftp
Copy link
Member

Screenshot 2026-03-06 at 15 31 38

📝 Changelog

If this PR introduces user-facing changes, please update the relevant Unreleased section in changelogs:

@egorikftp
Copy link
Member Author

@t-regbs FYI: Interactive preview available in IntelliJ IDEA 2026.1 EAP

@coderabbitai
Copy link

coderabbitai bot commented Mar 6, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 55414452-15c1-48e6-a97f-978bf139a2e2

📥 Commits

Reviewing files that changed from the base of the PR and between 5678966 and f268d28.

📒 Files selected for processing (5)
  • tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/webimport/material/MaterialSymbolsImportScreen.kt
  • tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/webimport/standard/bootstrap/BootstrapImportScreen.kt
  • tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/webimport/standard/boxicons/BoxIconsImportScreen.kt
  • tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/webimport/standard/lucide/LucideImportScreen.kt
  • tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/webimport/standard/remix/RemixImportScreen.kt
🚧 Files skipped from review as they are similar to previous changes (4)
  • tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/webimport/material/MaterialSymbolsImportScreen.kt
  • tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/webimport/standard/lucide/LucideImportScreen.kt
  • tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/webimport/standard/boxicons/BoxIconsImportScreen.kt
  • tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/webimport/standard/remix/RemixImportScreen.kt

Walkthrough

This pull request adds Compose UI preview support to five import screen files in the IDEA plugin: MaterialSymbols, Bootstrap, BoxIcons, Lucide, and Remix. Each file receives new preview-related imports and a private @Preview composable that wraps the respective screen with ProjectPreviewTheme and TiamatPreview. No runtime logic or public API signatures are changed.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: adding preview support to web import screens across multiple files.
Description check ✅ Passed The description includes a screenshot demonstrating the preview functionality and the changelog checklist template, though all changelog items remain unchecked.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch task/add-preview-for-web-import-screens

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@egorikftp egorikftp force-pushed the task/add-preview-for-web-import-screens branch from 5678966 to f268d28 Compare March 6, 2026 17:28
@egorikftp egorikftp merged commit fc3fa83 into main Mar 7, 2026
3 checks passed
@egorikftp egorikftp deleted the task/add-preview-for-web-import-screens branch March 7, 2026 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants