refactor: clarify pop_record removal policy constants#4
Merged
CompilError-bts merged 1 commit intomasterfrom Mar 31, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
pop_recordloop used hard-coded numeric stopping conditions that made the intended policy ("usually remove 2 records, sometimes 3 to preserve atomic units") hard to read, so the review suggested making the policy explicit and parameterized.Description
TARGET_RECORDS = 2andMAX_RECORDS = 3and rewrite the removal loop to usewhile removed < TARGET_RECORDSandif removed > 0 and removed + next_unit_count > MAX_RECORDS: break, preserving existing behavior while improving readability (astrbot/core/provider/provider.py).Testing
ruff format .andruff check ., and both checks passed.Codex Task