Skip to content

chore: fixed a api doc and added some comments #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ligangty merged 1 commit into from
Sep 24, 2024
Merged

chore: fixed a api doc and added some comments #275

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions charon/pkgs/maven.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -996,8 +996,8 @@ def _generate_metadatas(
what we should do here is:
* Scan and get the GA for the poms
* Search all poms in s3 based on the GA
* Use searched poms and scanned poms to generate
maven-metadata to refresh
* Use searched pomsto generate maven-metadata
to refresh
"""
ga_dict: Dict[str, bool] = {}
logger.debug("Valid poms: %s", poms)
Expand All @@ -1007,6 +1007,8 @@ def _generate_metadatas(
logger.debug("G: %s, A: %s", g, a)
g_path = "/".join(g.split("."))
ga_dict[os.path.join(g_path, a)] = True
# Note: here we don't need to add original poms, because
# they have already been uploaded to s3.
all_poms = []
meta_files = {}
for path, _ in ga_dict.items():
Expand Down