Feature of adding product manifest generating and removing #135
Conversation
Pull Request Test Coverage Report for Build 1851362673
💛 - Coveralls |
yma955
force-pushed
the
main
branch
2 times, most recently
from
c32fead to
94acb1e
Compare
charon/storage.py
Outdated
| 'uploading') | ||
| return | ||
|
|
||
| manifest_bucket = self.__client.Bucket(manifest_bucket_name) |
There was a problem hiding this comment.
You can use self.__get_bucket(name) instead.
charon/pkgs/maven.py
Outdated
|
|
||
| prefix_ = remove_prefix(prefix, "/") | ||
|
|
||
| manifest_name, manifest_full_path = write_manifest(valid_mvn_paths, top_level, prod_key) |
There was a problem hiding this comment.
I think this step can be skipped with a log if manifest_bucket_name is not specified.
charon/pkgs/maven.py
Outdated
| # 5. Do manifest uploading | ||
| logger.info("Start uploading manifest to s3") | ||
| s3_client.upload_manifest(manifest_name, manifest_full_path, target, manifest_bucket_name) | ||
| logger.info("Manifest uploading is done\n") |
There was a problem hiding this comment.
I think this step can be skipped with a log if manifest_bucket_name is not specified.
| # 4. Delete related manifest from s3 | ||
| logger.info("Start deleting manifest from s3") | ||
| s3_client.delete_manifest(prod_key, target, manifest_bucket_name) | ||
| logger.info("Manifest deletion is done\n") |
There was a problem hiding this comment.
I think this step can be skipped with a log if manifest_bucket_name is not specified.
There was a problem hiding this comment.
@ligangty The case was already covered inside the delete_manifest method, others are sorted based on the comment.
charon/pkgs/npm.py
Outdated
|
|
||
| prefix_ = remove_prefix(prefix, "/") | ||
|
|
||
| manifest_name, manifest_full_path = write_manifest(valid_paths, target_dir, product) |
There was a problem hiding this comment.
I think this step can be skipped with a log if manifest_bucket_name is not specified.
charon/pkgs/npm.py
Outdated
|
|
||
| logger.info("Start uploading manifest to s3") | ||
| client.upload_manifest(manifest_name, manifest_full_path, target, manifest_bucket_name) | ||
| logger.info("Manifest uploading is done\n") |
There was a problem hiding this comment.
I think this step can be skipped with a log if manifest_bucket_name is not specified.
|
|
||
| logger.info("Start deleting manifest from s3") | ||
| client.delete_manifest(product, target, manifest_bucket_name) | ||
| logger.info("Manifest deletion is done\n") |
There was a problem hiding this comment.
I think this step can be skipped with a log if manifest_bucket_name is not specified.
|
The tests are failed caused by downloading from repo 'appstream'. It seems that the mirrors can't access? @ligangty |
3 participants
No description provided.