Added try catch while creating the websocket connection#105
Merged
Pradhyumna02 merged 1 commit intoComcast:masterfrom Oct 9, 2017
Merged
Added try catch while creating the websocket connection#105Pradhyumna02 merged 1 commit intoComcast:masterfrom
Pradhyumna02 merged 1 commit intoComcast:masterfrom
Conversation
rotosonic
reviewed
Oct 6, 2017
public/lib/webSocket.js
Outdated
| this._request.close(); | ||
| try { | ||
| this._request.close(); | ||
| } catch (error) { |
Collaborator
There was a problem hiding this comment.
can you update to } catch (error) {// jshint ignore:line
Collaborator
|
1+ once comment addressed |
Pradhyumna02
force-pushed
the
WebSockets-Bug-Fix
branch
from
30ec651 to
e5de203
Compare
|
+1 lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: IE11 throws an error while trying to create websocket connection
How: Added try and catch while creating and closing the connection