Skip to content

Add Navtrail with dropdown#38

Merged
w3cj merged 11 commits intoCodingGarden:mainfrom
omar2205:add-nav-trail-component
Feb 17, 2023
Merged

Add Navtrail with dropdown#38
w3cj merged 11 commits intoCodingGarden:mainfrom
omar2205:add-nav-trail-component

Conversation

@omar2205
Copy link
Collaborator

This adds a dropdown menu and a user avatar

Not logged
image

Logged in
image

@omar2205
Copy link
Collaborator Author

big oof 😛

@omar2205
Copy link
Collaborator Author

@w3cj this error

Error:   10:23  error  Parse errors in imported module './NavTrail.svelte': '>' expected. (1:8)
import/no-named-as-default

is related to #37 issue

Put `LightSwitch` into a span
@w3cj
Copy link
Member

w3cj commented Feb 12, 2023

I think you will need to merge with main for the CI checks to pass.

@omar2205
Copy link
Collaborator Author

I just have to do another commit for it to recheck it

@brilvio
Copy link
Contributor

brilvio commented Feb 12, 2023

Your branch is 3 commits behind main, maybe rebase or merge main into your branch.

@w3cj
Copy link
Member

w3cj commented Feb 12, 2023

Regarding the $app multiple import error, I think the fix in the tsconfig.json might have been wrong. Can you try removing the $app aliases in there and add "./node_modules/@sveltejs/kit/types/ambient.d.ts" to the includes array? I'm not near a PC to try right now.

@omar2205
Copy link
Collaborator Author

removing the tsconfig fix results in import/no-unresolved

@w3cj
Copy link
Member

w3cj commented Feb 13, 2023

Please merge / rebase with master. I updated the eslint config to handle multiple $app imports.

@omar2205
Copy link
Collaborator Author

Still, we get import/no-named-as-default-member

@w3cj
Copy link
Member

w3cj commented Feb 13, 2023

Looks like the rule import/no-named-as-default-member is the issue instead of import/no-named-as-default??

@omar2205
Copy link
Collaborator Author

Not sure if it's both or just one of them.

@omar2205
Copy link
Collaborator Author

Yeah, we need both!

     'import/no-named-as-default': 0,
     'import/no-named-as-default-member': 0,

@w3cj
Copy link
Member

w3cj commented Feb 13, 2023

Let's disable these rules for .svelte files specifically. Do you mind opening another PR?

This section in the eslint config can be updated and we can remove 'import/no-named-as-default': 0, in the general rules:

	overrides: [
		{
			files: ['**/*.svelte'],
			parser: 'svelte-eslint-parser',
			parserOptions: {
				parser: '@typescript-eslint/parser',
			},
			rules: {
				'import/no-named-as-default': 0,
				'import/no-named-as-default-member': 0,
			},
		},
	],

@omar2205
Copy link
Collaborator Author

OK, will test it and open a PR if it worked!

@omar2205
Copy link
Collaborator Author

btw, I keep getting this warning

`parseForESLint` from parser `@typescript-eslint/parser` is invalid and will just be ignored

@w3cj w3cj merged commit 4c32926 into CodingGarden:main Feb 17, 2023
@omar2205 omar2205 deleted the add-nav-trail-component branch February 17, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants