Skip to content

Conversation

@AFatmaa
Copy link

@AFatmaa AFatmaa commented Dec 28, 2025

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

  • Fixed Infinite Loop: The hashtag page was crashing because it fetched data on every single render.

  • Fix Details: In hashtag.mjs, I added a check to stop unnecessary API calls.

    • First, I normalised the hashtag input (added # if it was missing).
    • Then, I compared it with state.currentHashtag.
    • The API request now runs only if the hashtag is different from the current state.
  • Test: Added a new test (hashtag.spec.mjs) to verify that the page sends only one request.

Questions

I don’t have any questions. Thank you!

@AFatmaa AFatmaa added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 📅 Sprint 1 Assigned during Sprint 1 of this module labels Dec 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 📅 Sprint 1 Assigned during Sprint 1 of this module

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

1 participant