Skip to content

Added "No review required" note and PR template #693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
illicitonion merged 2 commits into from
May 20, 2025
Merged

Added "No review required" note and PR template #693

illicitonion merged 2 commits into from
May 20, 2025

Conversation

@cjyuan
Copy link
Contributor

@cjyuan cjyuan commented May 19, 2025

Changelist

  • Added "No review required" note in README.md
  • Updated the link to the sample GitHomeworkTest PR in README.md
  • Added a PR template similar to the PR template used in all ITP modules

@cjyuan cjyuan requested a review from illicitonion May 19, 2025 21:42
illicitonion
illicitonion approved these changes May 20, 2025
View reviewed changes
Copy link
Member

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@illicitonion illicitonion merged commit 5dbd73c into CodeYourFuture:main May 20, 2025
chibu0070 added a commit to chibu0070/GitHomeworkTest that referenced this pull request Sep 15, 2025
@chibu0070
Added "No review required" note and PR template (CodeYourFuture#693)
2c1d5d9 
<!--

You must title your PR like this:

REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME

For example,

  London | May-2025 | Carol Owen | Sprint-1

-->

## Learners, PR Template
<!--
  The purpose of the self-checklist is to help ensure the quality and completeness of a PR submission.

  You must complete all the tasks in the self-checklist and tick the boxes for those you have finished.

  You can tick a box by changing [ ] to [x] (with no spaces inside the brackets).
-->

Self checklist

- [ ] I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
- [ ] My changes meet the requirements outlined in the `README.md` of this task

## Changelist

<!--
  When you submit a PR, you're submitting changes you made to your own copy (fork) of the repository and requesting a review of those changes.
  It is best practice to leave a brief description of the changes you have made.

  You must replace "Briefly explain your PR." with a brief description of the changes you have made.
-->
Briefly explain your PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@illicitonion illicitonion illicitonion approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cjyuan @illicitonion