WIP: Use Directory subclasses instead of DirTypes enum#6
Open
olmokramer wants to merge 6 commits intomasterfrom
Open
WIP: Use Directory subclasses instead of DirTypes enum#6olmokramer wants to merge 6 commits intomasterfrom
olmokramer wants to merge 6 commits intomasterfrom
Conversation
libre-man
reviewed
Nov 7, 2017
cgfs.py
Outdated
| assig_dir.insert(AssignmentSettingsFile(cgapi, assig['id'])) | ||
| assig_dir.insert( | ||
| RubricEditorFile( | ||
| cgapi, assig['id'], self.rubric_append_only |
cgfs.py
Outdated
| class AssignmentDirectory(Directory): | ||
| def load_submissions(self, latest_only): | ||
| try: | ||
| submissions = cgapi.get_submissions(self.id) |
Contributor
There was a problem hiding this comment.
I would propose to stop using this global variable for new code.
| @@ -109,10 +107,9 @@ def setattr(self, key, value): | |||
|
|
|||
|
|
|||
| class Directory(BaseFile): | |||
Contributor
There was a problem hiding this comment.
Should FixedDirectory also inherit from this class?
Contributor
Author
There was a problem hiding this comment.
I couldn't find a class named FixedDirectory?
Contributor
There was a problem hiding this comment.
Sorry I meant TempDirectory.
Contributor
Author
There was a problem hiding this comment.
It already does...
libre-man
force-pushed
the
master
branch
3 times, most recently
from
d4db8e1 to
29063e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make subclasses of the
Directoryclass to be used instead of theDirTypesenum.The new classes are:
RootDirectory,CourseDirectory,AssignmentDirectory,SubmissionDirectoryandRegularDirectory, named after the corresponding values of the enum.Also moves some functionality specific to those directories to the new classes, e.g. loading submissions is now in the
AssignmentDirectoryclass.Still WIP as I haven't been able to test it yet, but wanted to get it out there to get some initial feedback on it.