fix: avoid OOM caused by NULL pointer returned from malloc(0)#1822
Merged
fix: avoid OOM caused by NULL pointer returned from malloc(0)#1822
Conversation
Test Results 56 files ±0 56 suites ±0 3m 4s ⏱️ -56s Results for commit b640fc3. ± Comparison against base commit d9a73c3. This pull request removes 36 and adds 36 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
0utplay
approved these changes
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
It's left to the implementations of malloc if a
malloc(0)returns a NULL pointer or a non-null pointer. However, our validation logic checks if a NULL pointer is returned and treats it as an OOM.Modification
Always pass at least 1 to malloc, ensuring that we only get a NULL pointer if we're really out of memory.
Result
No more OOM errors thrown because of
malloc(0)calls returning a NULL pointer.