fix: add server name to lp context if not otherwise configured#1802
Merged
fix: add server name to lp context if not otherwise configured#1802
Conversation
derklaro
added
v: 4.X
0utplay
approved these changes
Nov 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The server key is an essential part of the luckperms context calculation. By default, it is taken from the LuckPerms config file, however, if the default value
globalis left unchanged, the key isn't added to the context. However, we do know the current server name and are able to add it to the LuckPerms context.Modification
Add the server key holding the current service name to the luckperms context if the server name is not specified in the LuckPerms configuration file.
Result
The server context key is correctly configured automatically by default. If the user wants to he can still change the value in the LuckPerms configuration to his needs.