Skip to content

fix: depend on official cloud dependencies in node-api#1780

Merged
derklaro merged 1 commit intonightlyfrom
cloud-dependency-node-api
Oct 15, 2025
Merged

fix: depend on official cloud dependencies in node-api#1780
derklaro merged 1 commit intonightlyfrom
cloud-dependency-node-api

Conversation

@derklaro
Copy link
Member

Motivation

The node-api currently depends on our custom cloud fork which is not ideal as it requires an additional repository to be defined when using the dependency with gradle.

Modification

Use the official cloud-api in the node-api module (changes in our fork are only implementation details).

Result

The node-api can be used without specifying additional repositories.

@derklaro derklaro added this to the 4.0.0-RC15 milestone Oct 15, 2025
@derklaro derklaro requested a review from 0utplay October 15, 2025 12:09
@derklaro derklaro self-assigned this Oct 15, 2025
@derklaro derklaro added v: 4.X This pull should be included in the 4.0 release in: node An issue/pull request releated to the node module code t: fix A pull request introducing a fix for a bug. a: api An issue/pull request that is related to api changes. labels Oct 15, 2025
@github-actions
Copy link

Test Results

 56 files  ±0   56 suites  ±0   4m 19s ⏱️ -1s
570 tests ±0  570 ✅ ±0  0 💤 ±0  0 ❌ ±0 
937 runs  ±0  937 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 0195cef. ± Comparison against base commit de0f24d.

@derklaro derklaro merged commit dcbffcd into nightly Oct 15, 2025
6 checks passed
@derklaro derklaro deleted the cloud-dependency-node-api branch October 15, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: api An issue/pull request that is related to api changes. in: node An issue/pull request releated to the node module code t: fix A pull request introducing a fix for a bug. v: 4.X This pull should be included in the 4.0 release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants