refactor: replace LazyMemoizingSupplier with StableValue#1768
Merged
refactor: replace LazyMemoizingSupplier with StableValue#1768
Conversation
derklaro
added
v: 4.X
0utplay
approved these changes
Oct 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
LazyMemoizingSupplier was added as Java 24 didn't have StableValues yet. They were added as a preview feature in jdk 25, providing better performance due to constant folding at runtime.
Modification
Drop our custom LazyMemoizingSupplier implementation and replace all uses with StableValue.
Result
Our custom function is removed in favor of a new jdk api that provides better runtime performance.
Other context
This api will change in jdk 26 again (see jep draft 526 / JDK-8366178), however the impact on our code will be minimal (looking at the proposed changes today) and given the performance benefits we should migrate regardeless.